After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700715 - Prevent users from being 'locked out'
Prevent users from being 'locked out'
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-20 13:42 UTC by Chris Cummins
Modified: 2013-06-03 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Don't let user disable own account (1.36 KB, patch)
2013-05-20 13:43 UTC, Chris Cummins 		accepted-commit_now Details | Review
Spliced screenshot showing a 'before and after' of the proposed patch (id=244779) (148.45 KB, image/png)
2013-05-23 10:36 UTC, Chris Cummins 		  Details

Description Chris Cummins 2013-05-20 13:42:10 UTC 
It is possible for the currently logged in user to disable their account and then be unable to undo this action. For example:

 1) Open Settings -> Users
 2) Unlock
 3) Select current user -> Change password -> 'Disable this account'
 4) Lock
 5) Now try and repeat this action.

From this state, it is no longer possible to unlock the user settings panel (as the password has been disabled), the user must manually recover with $ sudo passwd -u `whoami`, or log in as root.
Comment 1 Chris Cummins 2013-05-20 13:43:36 UTC 
Created attachment 244779 [details] [review]
user-accounts: Don't let user disable own account

This prevents the problem by removing the 'Disable this account' action from the password dialog of the currently logged in user.
Comment 2 Chris Cummins 2013-05-23 10:36:55 UTC 
Created attachment 245114 [details]
Spliced screenshot showing a 'before and after' of the proposed patch (id=244779)

This shows how the 'Disable this account' action is not available for the currently logged in user (does not affect other accounts). Excuse the amateurish gimp skills! ;-)
Comment 3 Thomas Wood 2013-05-31 16:11:34 UTC 
Review of attachment 244779 [details] [review]:

Patch looks good to me.
Comment 4 Michael Wood 2013-06-03 15:43:58 UTC 
gnome-3.8 - a107db388fff055b8be370cee5454de4e8489387
master - 1a770694edc1d62280634f3c5ddb25024ede8e22