After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700698 - Specify 'ripper' in the desktop file
Specify 'ripper' in the desktop file
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-20 08:57 UTC by Aleksander Morgado
Modified: 2013-05-21 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to try to fix the issue (792 bytes, patch)
2013-05-20 08:59 UTC, Aleksander Morgado 		rejected Details | Review
Added to keywords (776 bytes, patch)
2013-05-21 07:01 UTC, Aleksander Morgado 		committed Details | Review

Description Aleksander Morgado 2013-05-20 08:57:58 UTC 
I just wanted to look for a CD ripper and gnome-shell didn't yield any results when looking for "ripper". Had to go to the Software Center in Fedora to tell me that "Sound Juicer" is a "Clean and lean CD ripper".

The 'ripper' word could be included in the desktop file so that gnome-shell provides the result.
Comment 1 Aleksander Morgado 2013-05-20 08:59:09 UTC 
Created attachment 244761 [details] [review]
Patch to try to fix the issue
Comment 2 Bastien Nocera 2013-05-21 06:42:38 UTC 
Review of attachment 244761 [details] [review]:

::: data/sound-juicer.desktop.in.in
@@ +1,3 @@
 [Desktop Entry]
 _Name=Sound Juicer
+_GenericName=Audio CD Extractor/Ripper

Nope, add it to the keywords instead.
Comment 3 Aleksander Morgado 2013-05-21 07:01:56 UTC 
Created attachment 244897 [details] [review]
Added to keywords

How about like this?
Comment 4 Bastien Nocera 2013-05-21 07:18:27 UTC 
Review of attachment 244897 [details] [review]:

Looks good, though the number of keywords could probably be extended :)
Comment 5 Aleksander Morgado 2013-05-21 07:55:30 UTC 
> 
> Looks good, though the number of keywords could probably be extended :)

Is it worth adding keywords like "cd;extractor;" when they are already in the name? I can add those as well if you prefer.
Comment 6 Bastien Nocera 2013-05-21 07:57:08 UTC 
(In reply to comment #5)
> > 
> > Looks good, though the number of keywords could probably be extended :)
> 
> Is it worth adding keywords like "cd;extractor;" when they are already in the
> name?

It's not even a case of "worth it", it's just not needed.

> I can add those as well if you prefer.

No, it's fine, but there's certainly a number of keywords that slip my mind right now.
Comment 7 Aleksander Morgado 2013-05-21 12:05:58 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.