After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700691 - Do not use X11 if not running inside an X session
Do not use X11 if not running inside an X session
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-20 07:20 UTC by Iago Toral
Modified: 2013-05-20 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.95 KB, patch)
2013-05-20 07:23 UTC, Iago Toral 		accepted-commit_now Details | Review

Description Iago Toral 2013-05-20 07:20:49 UTC 
When running Epiphany on Wayland I get a crash on startup. This is because of some code to compute a timestamp that assumes we are running on X.
Comment 1 Iago Toral 2013-05-20 07:23:18 UTC 
Created attachment 244753 [details] [review]
Patch

Make sure that user time fallback code only runs when we are indeed inside an X session. This patch enables Epiphany to start and run in Wayland.
Comment 2 Xan Lopez 2013-05-20 09:25:33 UTC 
Review of attachment 244753 [details] [review]:

This is obviously better than crashing, but ideally we should re-implement the same functionality somehow :)

Maybe add a FIXME or something.
Comment 3 Claudio Saavedra 2013-05-20 10:05:59 UTC 
Added a FIXME and pushed.

commit d5ddd68f50bafcbdc45870ef7f8f92f57e516587
Author: Iago Toral Quiroga <itoral@igalia.com>
Date:   Mon May 20 09:07:10 2013 +0200

    Make sure we only rely on X11 to obtain timestamps when we are running in a X session
    
    This avoids a startup crash when running on Wayland.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=700691