GNOME Bugzilla – Bug 700644
Restore full make check
Last modified: 2013-05-20 18:12:51 UTC
Now that we have --enable-installed-tests, we can use the jsunit we build and run it against uninstalled files.
Created attachment 244724 [details] [review] Restore full make check
Review of attachment 244724 [details] [review]: ::: Makefile-test.am @@ +25,3 @@ + +if BUILDOPT_INSTALL_TESTS +TEST_PROGS += jsunit I think this should be outside the conditional, otherwise "make check" won't work unless you pass --enable-installed-tests. @@ +38,2 @@ @echo "" @echo "NOTICE" We can just kill the NOTICE now right? That was necessary when we didn't have the traditional "make check". So really this change should just be deleting the BUILDOPT_INSTALL_TESTS stuff and having it all always on.
(In reply to comment #2) > Review of attachment 244724 [details] [review]: > > ::: Makefile-test.am > @@ +25,3 @@ > + > +if BUILDOPT_INSTALL_TESTS > +TEST_PROGS += jsunit > > I think this should be outside the conditional, otherwise "make check" won't > work unless you pass --enable-installed-tests. I think that depends on the expected behavior here. I was aiming for a model where: - you pass --enable-installed-tests, you get installed tests and make check with gjs-tests + jsunit - you don't pass --enable-installed-tests, you only get uninstalled gjs-tests
(In reply to comment #3) > I think that depends on the expected behavior here. > I was aiming for a model where: > - you pass --enable-installed-tests, you get installed tests and make check > with gjs-tests + jsunit But since you made jsunit work uninstalled (right?) why not just have it be *always* built and run under make check. In other words we're back to basically our starting point, plus the tests can optionally be installed. Like how glib works.
Created attachment 244835 [details] [review] Restore full make check Now that we have --enable-installed-tests, we can use the jsunit we build and run it against uninstalled files.
Review of attachment 244835 [details] [review]: This looks right.
Attachment 244835 [details] pushed as 75b04f0 - Restore full make check