After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700644 - Restore full make check
Restore full make check
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-19 17:14 UTC by Giovanni Campagna
Modified: 2013-05-20 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Restore full make check (1.95 KB, patch)
2013-05-19 17:14 UTC, Giovanni Campagna
reviewed Details | Review
Restore full make check (4.35 KB, patch)
2013-05-20 16:32 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-05-19 17:14:41 UTC
Now that we have --enable-installed-tests, we can use the jsunit
we build and run it against uninstalled files.
Comment 1 Giovanni Campagna 2013-05-19 17:14:43 UTC
Created attachment 244724 [details] [review]
Restore full make check
Comment 2 Colin Walters 2013-05-19 20:06:14 UTC
Review of attachment 244724 [details] [review]:

::: Makefile-test.am
@@ +25,3 @@
+
+if BUILDOPT_INSTALL_TESTS
+TEST_PROGS += jsunit

I think this should be outside the conditional, otherwise "make check" won't work unless you pass --enable-installed-tests.

@@ +38,2 @@
 	@echo ""
 	@echo "NOTICE"

We can just kill the NOTICE now right?  That was necessary when we didn't have the traditional "make check".

So really this change should just be deleting the BUILDOPT_INSTALL_TESTS stuff and having it all always on.
Comment 3 Giovanni Campagna 2013-05-19 21:07:38 UTC
(In reply to comment #2)
> Review of attachment 244724 [details] [review]:
> 
> ::: Makefile-test.am
> @@ +25,3 @@
> +
> +if BUILDOPT_INSTALL_TESTS
> +TEST_PROGS += jsunit
> 
> I think this should be outside the conditional, otherwise "make check" won't
> work unless you pass --enable-installed-tests.

I think that depends on the expected behavior here.
I was aiming for a model where:
- you pass --enable-installed-tests, you get installed tests and make check with gjs-tests + jsunit
- you don't pass --enable-installed-tests, you only get uninstalled gjs-tests
Comment 4 Giovanni Campagna 2013-05-19 21:07:38 UTC
(In reply to comment #2)
> Review of attachment 244724 [details] [review]:
> 
> ::: Makefile-test.am
> @@ +25,3 @@
> +
> +if BUILDOPT_INSTALL_TESTS
> +TEST_PROGS += jsunit
> 
> I think this should be outside the conditional, otherwise "make check" won't
> work unless you pass --enable-installed-tests.

I think that depends on the expected behavior here.
I was aiming for a model where:
- you pass --enable-installed-tests, you get installed tests and make check with gjs-tests + jsunit
- you don't pass --enable-installed-tests, you only get uninstalled gjs-tests
Comment 5 Colin Walters 2013-05-19 23:12:46 UTC
(In reply to comment #3)

> I think that depends on the expected behavior here.
> I was aiming for a model where:
> - you pass --enable-installed-tests, you get installed tests and make check
> with gjs-tests + jsunit

But since you made jsunit work uninstalled (right?) why not just have it be *always* built and run under make check.  In other words we're back to basically our starting point, plus the tests can optionally be installed.  Like how glib works.
Comment 6 Giovanni Campagna 2013-05-20 16:32:53 UTC
Created attachment 244835 [details] [review]
Restore full make check

Now that we have --enable-installed-tests, we can use the jsunit
we build and run it against uninstalled files.
Comment 7 Colin Walters 2013-05-20 17:28:15 UTC
Review of attachment 244835 [details] [review]:

This looks right.
Comment 8 Giovanni Campagna 2013-05-20 18:12:47 UTC
Attachment 244835 [details] pushed as 75b04f0 - Restore full make check