Created attachment 244716 [details] [review]
Use the new GtkBuilder support in GWeather

Review of attachment 244716 [details] [review]:

Thanks for the patch, it's always nice to see code removed :)

Just a minor comment below...

::: src/world.vala
@@ -24,2 +22,2 @@
 private GWeather.Location get_world_location () {
-    if (gweather_world == null) {
+    return new GWeather.Location.world (true);

This is a bit confusing, since it looks a lot like we are returning a new instance all the time...

Anyway, get_world_location is now used in just one place to call deserialize(), so please remove this helper function and call "new GWeather.Location.world (true);" locally

Created attachment 244717 [details] [review]
Use the new GtkBuilder support in GWeather

With that, we can move the location entry to Glade and simplify
our code.

Review of attachment 244717 [details] [review]:

One more tiny nitpick, once you fix it feel free to push

::: src/world.vala
@@ +150,3 @@
+                // This looks like a constructor for historic reasons
+                // it returns the same instance after the first call
+                var world = new GWeather.Location.world (true);

even if it is returning the same instance, let's move this outside the foreach loop

Attachment 244717 [details] pushed as c75f6e2 - Use the new GtkBuilder support in GWeather