After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700570 - ui: don't lose the interface setting
ui: don't lose the interface setting
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: rygel-preferences
git master
Other All
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-18 11:16 UTC by Andreas Henriksson
Modified: 2013-05-28 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: don't lose the interface setting (1.86 KB, patch)
2013-05-18 11:16 UTC, Andreas Henriksson 		none Details | Review
ui: don't lose the interface setting (1.86 KB, patch)
2013-05-18 11:37 UTC, Andreas Henriksson 		committed Details | Review
ui: don't lose the interface setting (1.87 KB, patch)
2013-05-18 11:43 UTC, Andreas Henriksson 		committed Details | Review

Description Andreas Henriksson 2013-05-18 11:16:16 UTC 
Just opening and closing rygel-preferences would result in
the interface setting getting set to blank in the configuration.
Fixing the TODO item in the source to set the active interface
(last added item) was all that was needed.
Comment 1 Andreas Henriksson 2013-05-18 11:16:19 UTC 
Created attachment 244603 [details] [review]
ui: don't lose the interface setting
Comment 2 Andreas Henriksson 2013-05-18 11:37:55 UTC 
Created attachment 244604 [details] [review]
ui: don't lose the interface setting

Just opening and closing rygel-preferences would result in
the interface setting getting set to blank in the configuration.
Fixing the TODO item in the source to set the active interface
(last added item) was all that was needed.
Comment 3 Andreas Henriksson 2013-05-18 11:40:19 UTC 
The above update fixed a couple of more minor style issues.

Fwiw, 0.18.2 patch available at http://fatal.se/tmp/0001-ui-don-t-lose-the-interface-setting.patch
Comment 4 Andreas Henriksson 2013-05-18 11:43:37 UTC 
Created attachment 244605 [details] [review]
ui: don't lose the interface setting

Just opening and closing rygel-preferences would result in
the interface setting getting set to blank in the configuration.
Fixing the TODO item in the source to set the active interface
(last added item) was all that was needed.
Comment 5 Jens Georg 2013-05-28 07:58:32 UTC 
Review of attachment 244604 [details] [review]:

Thanks
Comment 6 Jens Georg 2013-05-28 08:01:49 UTC 
Attachment 244605 [details] pushed as 8c21ad9 - ui: don't lose the interface setting