GNOME Bugzilla – Bug 700564
Diff view: allow easy review/commenting. (ex: make it "copy" friendly)
Last modified: 2018-05-22 12:16:02 UTC
I wish the diff view would have a different layout, so we can copy parts Both panes could be in two different columns. Currently if you want to copy/paste a part of it (to comment on it), you get online from each pane alternated. Alternatively, the page could support user comments/review. Similar to what bugzilla does with patch review.
I just notice the little "n" links, that can be used to reference a diff. This could be used as a workaround. It could be used as a workaround, but when giving a link, it is very hard to realize what the page is pointing at. The targeted diff could be highlighted. For example but using the :target pseudo class in CSS. See attached example. Example page: https://l10n.gnome.org/vertimus/diff/168043/0/0/#difflib_chg_to5058__7 Actually, the target is line 24, which is not even on the screen!
Created attachment 244596 [details] CSS example to highlight an Id target
(In reply to comment #0) > I wish the diff view would have a different layout, so we can copy parts I agree that it's currently difficult to copy text from one side or the other of the diff if you don't know the trick (or if your browser doesn't implement it). In Firefox, keeping Ctrl pressed while dragging the mouse allows to make column-wise selections. It doesn't work in Epiphany. :-( > Both panes could be in two different columns. What does that mean? They already are in two different columns in the same table. > Currently if you want to copy/paste a part of it (to comment on it), > you get online from each pane alternated. This happens because the content is actually in a table and browsers select content by rows instead of by columns (which makes sense in most cases, but isn't very good for us). Having our diff content in a table is the Right Thing semantically (and if you disable CSS, it may give you a better understanding of the layout). I've looked for ways to change that behaviour, but so far no success. > Alternatively, the page could support user comments/review. Similar to what > bugzilla does with patch review. This feature is actually implemented by a plugin developed for GNOME by Owen Taylor. The plugin is splinter (https://bugzilla.gnome.org/browse.cgi?product=splinter). I remember asking Owen if it would be feasible to port splinter for Damned lies, but I can't find any bug report and I don't think I ever got an answer. Note that splinter displays content in a table as well and suffers from the same selection issue.
(In reply to comment #3) > In Firefox, keeping Ctrl pressed while dragging the mouse allows to make > column-wise selections. It doesn't work in Epiphany. :-( This could be documented on the page itself. > > Both panes could be in two different columns. > > What does that mean? They already are in two different columns in the same > table. for example a table (but it could be some CSS) with one row and 2 columns. Then in each of 2 cells a table with diff output, one row per line. > Having our diff content in a table is the Right Thing semantically (and if you > disable CSS, it may give you a better understanding of the layout). > > I've looked for ways to change that behaviour, but so far no success. see above > > Alternatively, the page could support user comments/review. Similar to what > > bugzilla does with patch review. > > This feature is actually implemented by a plugin developed for GNOME by Owen > Taylor. The plugin is splinter > (https://bugzilla.gnome.org/browse.cgi?product=splinter). I remember asking > Owen if it would be feasible to port splinter for Damned lies, but I can't find > any bug report and I don't think I ever got an answer. > > Note that splinter displays content in a table as well and suffers from the > same selection issue. If we can comment on the diff (and let's say, that the comments are pushed into the module page's comment textarea, as splinter does), then there is not much need of copy paste. At least not for commenting/reviewing. Feel free to push for it.
Created attachment 244598 [details] example of 2 columns table layout Currently the diff is in a table, WHICH HAS N ROWS, and each of n row has 2 columns (actually more) We should put the diff in a table, WHICH HAS 2 COLUMNS, and each of 2 columns has n rows (that is, inside a sub-table).
(In reply to comment #5) > Created an attachment (id=244598) [details] > example of 2 columns table layout Ok, comment 4 didn't help to understand that, but this example does. Thanks. > Currently the diff is in a table, WHICH HAS N ROWS, > and each of n row has 2 columns (actually more) > > We should put the diff in a table, WHICH HAS 2 COLUMNS, > and each of 2 columns has n rows (that is, inside a sub-table). This breaks semantics. The fact that a line on the left is on the same row as another line on the right conveys a meaning. We don't want to lose that.
> > Currently the diff is in a table, WHICH HAS N ROWS, > > and each of n row has 2 columns (actually more) > > > > We should put the diff in a table, WHICH HAS 2 COLUMNS, > > and each of 2 columns has n rows (that is, inside a sub-table). > > This breaks semantics. what semantic? > The fact that a line on the left is on the same row as > another line on the right conveys a meaning. We don't want to lose that. How is that useful?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/damned-lies/issues/47.