GNOME Bugzilla – Bug 700539
right click on unsupported track removes error icon
Last modified: 2013-07-16 10:00:50 UTC
When I right click on an unsupported track it removes the error icon.
Actually, it's a bit more than this. Right click on a supported track will show/hide the "Playing" icon to the music in some places and will simply start to play the music in another. According with Seif, right click should do anything by design. I'm a bit confused in this code. I'm trying to understand who is receiving and treating the mouse click in the Albums view and in the Songs view. It was pretty clear in the Artists view. For some reason, looks like it's not exactly treated as a button-{press,release}-event in the Albums and Songs views. Is there some reason for this? Tips are welcome :-)
Album and songs view are Mainviews, while Artist views using a grid, that's probably why.
Created attachment 246292 [details] [review] Only allow left-button click to trigger events By design we don't want that {right,middle}-button click triggers any kind of action in gnome-music.
(In reply to comment #3) This patch still doesn't fix the problem entirely. I'm working on the McCann's issue now.
Review of attachment 246292 [details] [review]: ::: src/view.js @@ +312,3 @@ + let button = Gtk.get_current_event().get_button()[1]; + + if (button == 1) { to reduce the diff size and for better indention why not use: if (button != 1) return; @@ +355,3 @@ + let button = Gtk.get_current_event().get_button()[1]; + + if (button == 1) { same @@ +565,3 @@ + let button = Gtk.get_current_event().get_button()[1]; + + if (button == 1) { same ::: src/widgets.js @@ +125,3 @@ + let button = Gtk.get_current_event().get_button()[1]; + + if (button == 1) { to reduce the diff size and for better indention why not use: if (button != 1) return; @@ +619,3 @@ + let button = event.get_button()[1]; + + if (button == 1) { same here
Created attachment 246385 [details] [review] Only allow left-button click to trigger events By design we don't want that {right,middle}-button click triggers any kind of action in gnome-music.
Review of attachment 246385 [details] [review]: No need to update libgd, please remove it from the patch
Created attachment 246396 [details] [review] Only allow left-button click to trigger events By design we don't want that {right,middle}-button click triggers any kind of action in gnome-music.
After the tests were removed we can push it, thanks! The following fix has been pushed: a543620 Only allow left-button click to trigger events
Created attachment 249260 [details] [review] Only allow left-button click to trigger events By design we don't want that {right,middle}-button click triggers any kind of action in gnome-music.