After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700530 - Warning on startup
Warning on startup
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-17 14:33 UTC by Bastien Nocera
Modified: 2013-05-17 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Fix warnings for the GVariant-encoded parameters (1.71 KB, patch)
2013-05-17 15:34 UTC, Emanuele Aina 		accepted-commit_now Details | Review
shell: Fix warnings for the GVariant-encoded parameters (1.57 KB, patch)
2013-05-17 16:02 UTC, Emanuele Aina 		committed Details | Review
shell: Fix warnings for the GVariant-encoded parameters (1.57 KB, patch)
2013-05-17 16:29 UTC, Emanuele Aina 		committed Details | Review

Description Bastien Nocera 2013-05-17 14:33:26 UTC 
Looks like a fallout of the argv move to gvariant.

** (gnome-control-center:26704): WARNING **: Ignoring additional parameters
Comment 1 Emanuele Aina 2013-05-17 15:34:10 UTC 
Created attachment 244546 [details] [review]
shell: Fix warnings for the GVariant-encoded parameters

This fixes a spurious warning about ignored parameters due to the
variant not being NULL since it now contains the flags dictionary.
Comment 2 Bastien Nocera 2013-05-17 15:39:55 UTC 
Review of attachment 244546 [details] [review]:

Looks good otherwise.

::: shell/cc-panel.c
@@ +89,3 @@
+          return;
+
+        n_parameters = g_variant_n_children (parameters);

Assign this in the check above:
if (parameters == NULL)
  return;
n_params = ...
if (n_params == 0)
  return;
Comment 3 Emanuele Aina 2013-05-17 16:02:29 UTC 
Created attachment 244550 [details] [review]
shell: Fix warnings for the GVariant-encoded parameters

This fixes a spurious warning about ignored parameters due to the
variant not being NULL since it now contains the flags dictionary.
Comment 4 Bastien Nocera 2013-05-17 16:06:21 UTC 
Review of attachment 244550 [details] [review]:

Looks good.
Comment 5 Emanuele Aina 2013-05-17 16:29:11 UTC 
The following fix has been pushed:
4e42a36 shell: Fix warnings for the GVariant-encoded parameters
Comment 6 Emanuele Aina 2013-05-17 16:29:18 UTC 
Created attachment 244553 [details] [review]
shell: Fix warnings for the GVariant-encoded parameters

This fixes a spurious warning about ignored parameters due to the
variant not being NULL since it now contains the flags dictionary.