After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700511 - wacom: Do not unref variant consumed by GSettings
wacom: Do not unref variant consumed by GSettings
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: Joaquim Rocha
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-17 10:27 UTC by Joaquim Rocha
Modified: 2013-05-17 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Do not unref variant consumed by GSettings (792 bytes, patch)
2013-05-17 10:27 UTC, Joaquim Rocha 		accepted-commit_now Details | Review

Description Joaquim Rocha 2013-05-17 10:27:20 UTC 
The value being set is floating so the reference is consumed by GSettings
who already unrefs it so this call was making a critical warning to be shown.
Comment 1 Joaquim Rocha 2013-05-17 10:27:23 UTC 
Created attachment 244499 [details] [review]
wacom: Do not unref variant consumed by GSettings

This avoids a critical warning.
Comment 2 Bastien Nocera 2013-05-17 14:15:02 UTC 
Review of attachment 244499 [details] [review]:

Looks good.
Comment 3 Joaquim Rocha 2013-05-17 14:23:01 UTC 
Pushed.