GNOME Bugzilla – Bug 700498
Set OLED label for non-custom shortcuts
Last modified: 2013-07-15 16:40:43 UTC
For the help and switch monitor button actions, we should also set an OLED label.
Created attachment 244571 [details] [review] Pass action name as OLED label
The patch works fine, but OLED capacity is very limited. Strings like: "Show On-Screen Help" barely fits, "Wyświetlenie pomocy ekranowej" (Polish) doesn't fit at all, the same for "Mostrar la ayuda en pantalla" (Spanish). I'm not sure what's the best way to fix it as it's a corner case - the text on the on-screen help looks fine. Maybe icons? https://github.com/PrzemoF/i4oled/blob/master/icons/help.png https://github.com/PrzemoF/i4oled/blob/master/icons/switch-monitor.png And that's how they look on Intuos4: http://firszt.eu/gnome-devel/help_switch_monitor_icons_photo.jpg
That patch need more work. 1. Resetting label when user goes back to None as button mapping 2. Displaying proper keystroke when user switches back from None to a previously defined keystroke. (define keystroke->switch mapping to none->switch to keystroke WITHOUT defining a new key.
Created attachment 244691 [details] [review] Pass action name as OLED label, reset to blank on no action Setting OLED label has been moved to a new location (accel_edited_callback -> accel_set_func) because after "map keystroke"->"map none"->"map keystroke" the OLED wasn't updated because accelerator wasn't edited, but it was set using old value.
Review of attachment 244691 [details] [review]: Looks good.
(In reply to comment #2) > The patch works fine, but OLED capacity is very limited. Strings like: "Show > On-Screen Help" barely fits, "Wyświetlenie pomocy ekranowej" (Polish) doesn't > fit at all, the same for "Mostrar la ayuda en pantalla" (Spanish). I'm not sure > what's the best way to fix it as it's a corner case - the text on the on-screen > help looks fine. > > Maybe icons? > https://github.com/PrzemoF/i4oled/blob/master/icons/help.png > https://github.com/PrzemoF/i4oled/blob/master/icons/switch-monitor.png > > And that's how they look on Intuos4: > http://firszt.eu/gnome-devel/help_switch_monitor_icons_photo.jpg We'll definitely need to use icons for a lot of the shortcuts. I would prefer if the icons were derived from the GNOME symbolic icons, though they might not always be exactly fit for purpose.
> We'll definitely need to use icons for a lot of the shortcuts. I would prefer > if the icons were derived from the GNOME symbolic icons, though they might not > always be exactly fit for purpose. I agree. I'll try to convert some of them to 64x32x4bit. Is it OK to use my server or I should get familiar with live.gnome.org?
(In reply to comment #7) > > We'll definitely need to use icons for a lot of the shortcuts. I would prefer > > if the icons were derived from the GNOME symbolic icons, though they might not > > always be exactly fit for purpose. > > I agree. I'll try to convert some of them to 64x32x4bit. This was the point of the GdkPixbuf helper function I requested :) You can convert, in software, the SVG icon rendered to 32x32 to a GdkPixbuf with 4 bit colour, and transform it into a "base64:" icon. > Is it OK to use my > server or I should get familiar with live.gnome.org? I don't understand what you want to do there.
(In reply to comment #8) > (In reply to comment #7) > > > We'll definitely need to use icons for a lot of the shortcuts. I would prefer > > > if the icons were derived from the GNOME symbolic icons, though they might not > > > always be exactly fit for purpose. > > > > I agree. I'll try to convert some of them to 64x32x4bit. > > This was the point of the GdkPixbuf helper function I requested :) OK :-) > You can convert, in software, the SVG icon rendered to 32x32 to a GdkPixbuf > with 4 bit colour, and transform it into a "base64:" icon. > > > Is it OK to use my > > server or I should get familiar with live.gnome.org? > > I don't understand what you want to do there. I'm making external conversion svg -> 64x43x4bit grayscale and I wanted to upload the files somewhere. I'll use my server for the icons & photos of the icons on the tablet.
I made a test rendering from gnome symbolic icons and from the same svg, but converted to png. That's how they look on the tablet: http://firszt.eu//gnome-devel/icons_white_png_vs_grey_resized.png Shape is OK (I made some changes to use the alpha channel), but because all symbolic icons are grey we're not using full "dynamic range" of the OLEDs. Simply white icons look much better. I could "brighten" them in the rendering part of the patch, but I don't think it's the right solution. Ideas: 1. Make a separate set of white icons (hmmm.. no good) 2. Solve the problem in svg icon->gdkpixbuf generation, wherever it will be handled. GdkPixbuf would have to be normalised to use full grayscale even if the original svg icon is not using it. 3. Leave it like it is now (I don't like this one) P.S. We should open a new bug to discuss icons
Created attachment 249226 [details] [review] wacom: Show hard-coded action names on OLED too Show hard-coded action names on OLED as well, not just for custom actions.
Pushed with the commit message fixed up a little. Attachment 249226 [details] pushed as 3708eab - wacom: Show hard-coded action names on OLED too