After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700469 - wizard: Don't show 'setup' step in non-express installs
wizard: Don't show 'setup' step in non-express installs
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-16 16:27 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Don't show 'setup' step in non-express installs (1.21 KB, patch)
2013-05-16 16:28 UTC, Christophe Fergeau 		rejected Details | Review
wizard: Never make the 'Express Install' label insensitive (2.40 KB, patch)
2013-05-17 19:33 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-05-16 16:27:59 UTC 
If you disable express install, and then go back, you get to
the setup screen with everything grayed out except for 'back'.
Better to just skip this screen in this case.
Comment 1 Christophe Fergeau 2013-05-16 16:28:03 UTC 
Created attachment 244432 [details] [review]
wizard: Don't show 'setup' step in non-express installs
Comment 2 Zeeshan Ali 2013-05-17 14:10:57 UTC 
Review of attachment 244432 [details] [review]:

That is not correct, user should be able to change his/her mind about express and non-express installation until he/she hits 'Create'.
Comment 3 Christophe Fergeau 2013-05-17 14:19:38 UTC 
AH the bug is the switch being shown unsensitive while it's not, the wizard screen really looks like you cannot do anything on that screen.
Comment 4 Christophe Fergeau 2013-05-17 19:33:22 UTC 
Created attachment 244574 [details] [review]
wizard: Never make the 'Express Install' label insensitive

When doing a non-express install, all the other UI elements should
be unsensitive, but the 'Express Install' switch itself is still
sensitive if the user wants to reenable express install, so
its label should always be sensitive as well.
Comment 5 Zeeshan Ali 2013-05-17 23:33:54 UTC 
Review of attachment 244574 [details] [review]:

ACK

::: src/unattended-installer.vala
@@ +449,2 @@
         foreach (var child in setup_grid.get_children ())
+            if ((child != express_label) && (child != express_toggle))

The inner '()' seems redundant to me here but not strong feelings either way.
Comment 6 Christophe Fergeau 2013-05-21 09:47:39 UTC 
Attachment 244574 [details] pushed as 2a11d97 - wizard: Never make the 'Express Install' label insensitive