After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700392 - goa: Be more intelligent about the visibility on network status
goa: Be more intelligent about the visibility on network status
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-15 14:23 UTC by Michael Wood
Modified: 2013-05-15 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goa: Be more intelligent about the visibility on network status (2.93 KB, patch)
2013-05-15 14:23 UTC, Michael Wood 		reviewed Details | Review
goa: Be more intelligent about the visibility on network status (updated patch) (2.95 KB, patch)
2013-05-15 14:56 UTC, Michael Wood 		accepted-commit_now Details | Review

Description Michael Wood 2013-05-15 14:23:23 UTC 
If an account has been configured or if you're viewing page don't change
the visibility. This can be jarring if you lose connection when on the
page or if you want to remove an account but lost connection.
Comment 1 Michael Wood 2013-05-15 14:23:24 UTC 
Created attachment 244328 [details] [review]
goa: Be more intelligent about the visibility on network status

If an account has been configured or if you're viewing page don't change
the visibility. This can be jarring if you lose connection when on the
page or if you want to remove an account but lost connection.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-15 14:30:20 UTC 
Review of attachment 244328 [details] [review]:

::: gnome-initial-setup/pages/goa/gis-goa-page.c
@@ +341,1 @@
+  available += priv->accounts_exist;

Clever, but I'd prefer available = available | priv->accounts_exist;
Comment 3 Michael Wood 2013-05-15 14:56:39 UTC 
Created attachment 244330 [details] [review]
goa: Be more intelligent about the visibility on network status (updated patch)
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-15 14:57:44 UTC 
Review of attachment 244330 [details] [review]:

ACN with this fixed.

::: gnome-initial-setup/pages/goa/gis-goa-page.c
@@ +341,1 @@
+  available = (available | priv->accounts_exist);

Er, whoops, I meant for that to be ||.
Comment 5 Michael Wood 2013-05-15 15:22:00 UTC 
Ok, pushed with change as above. 60e4fdc38c99ff530a551d1430a3518db4f92564