After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700349 - keyboard: Remove the input source switcher helper
keyboard: Remove the input source switcher helper
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on:
Blocks: 700346
 
 
Reported: 2013-05-14 22:44 UTC by Rui Matos
Modified: 2013-05-24 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Remove the input source switcher helper (22.67 KB, patch)
2013-05-14 22:45 UTC, Rui Matos 		committed Details | Review
keyboard: Convert the XKB group switch option from libgnomekbd (1.42 KB, patch)
2013-05-14 22:45 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-05-14 22:44:58 UTC 
See patches.
Comment 1 Rui Matos 2013-05-14 22:45:01 UTC 
Created attachment 244260 [details] [review]
keyboard: Remove the input source switcher helper

Mutter and gnome-shell will handle that task going forward.
Comment 2 Rui Matos 2013-05-14 22:45:05 UTC 
Created attachment 244261 [details] [review]
keyboard: Convert the XKB group switch option from libgnomekbd

Mutter and gnome-shell now use this to switch input sources so we
should convert it too.
Comment 3 Bastien Nocera 2013-05-17 08:24:18 UTC 
Review of attachment 244260 [details] [review]:

::: data/org.gnome.settings-daemon.peripherals.gschema.xml.in.in
@@ -107,3 @@
       <description>The remembered state of the NumLock LED.</description>
     </key>
-    <key name="input-sources-switcher" enum="org.gnome.settings-daemon.GsdInputSourcesSwitcher">

This can't go in gnome-3-8, otherwise it would break mixed versions of g-s-d and gnome-control-center.
Comment 4 Bastien Nocera 2013-05-17 08:25:32 UTC 
Review of attachment 244261 [details] [review]:

Fine.
Comment 5 Rui Matos 2013-05-24 21:28:48 UTC 
Attachment 244260 [details] pushed as ec7b1ec - keyboard: Remove the input source switcher helper
Attachment 244261 [details] pushed as cf544fc - keyboard: Convert the XKB group switch option from libgnomekbd