GNOME Bugzilla – Bug 700322
More network cleanups
Last modified: 2013-05-15 15:15:52 UTC
Hacking more on the aggregate menu caused these to appear.
Created attachment 244213 [details] [review] network: Remove semi-complex primary device finding According to dcbw (and some updated documentation), there will always be a 1:1 correspondence between NMActiveConnection and an NMDevice.
Created attachment 244214 [details] [review] network: Remove an unused getter
Created attachment 244215 [details] [review] network: Use checkConnection to set up the initial connections
Created attachment 244216 [details] [review] network: Don't pass this._connections to the VPN section It's always empty by this point.
Created attachment 244217 [details] [review] network: Use accessPointAdded to add initial access points This is technically a smidge slower due to the constant bisect insert, but since this should only happen when we make a Wi-Fi dialog, it's insignificant.
Review of attachment 244213 [details] [review]: Yes.
Review of attachment 244214 [details] [review]: Yes.
Review of attachment 244215 [details] [review]: You had a better commit message in a previous patch, didn't you? I mean, you explained that you're regressing on performance, but the resulting code is cleaner. Btw, the compromise is acceptable for me, so this is acn.
Review of attachment 244216 [details] [review]: Yes.
Review of attachment 244217 [details] [review]: Ok
Attachment 244213 [details] pushed as cd9c5b9 - network: Remove semi-complex primary device finding Attachment 244214 [details] pushed as f6e7034 - network: Remove an unused getter Attachment 244215 [details] pushed as cdbed0c - network: Use checkConnection to set up the initial connections Attachment 244216 [details] pushed as 30c64ba - network: Don't pass this._connections to the VPN section Attachment 244217 [details] pushed as 6330379 - network: Use accessPointAdded to add initial access points