After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700317 - Photos can be taken / videos recorded while in the effect screen
Photos can be taken / videos recorded while in the effect screen
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal major
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 700314 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-14 16:29 UTC by pnmanolova
Modified: 2013-06-04 16:39 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
The proposed fix (896 bytes, patch)
2013-05-14 16:30 UTC, pnmanolova
rejected Details | Review

Description pnmanolova 2013-05-14 16:29:46 UTC
The user can take photos and record videos while in the effect selector screen.

To reproduce:

1. Start Cheese
2. Press on "Effects"
3. Click "take a photo"
4. Click on "no effect" (top left)
5. The countdown seems to be active
6. Observe the images taken
Comment 1 pnmanolova 2013-05-14 16:30:13 UTC
Created attachment 244205 [details] [review]
The proposed fix
Comment 2 David King 2013-05-14 16:43:22 UTC
*** Bug 700314 has been marked as a duplicate of this bug. ***
Comment 3 David King 2013-05-14 17:16:26 UTC
Comment on attachment 244205 [details] [review]
The proposed fix

Thanks for the report. I fixes this in a a better way in commit bfaafd4b5af9800e6c7425d83aa3b26283659756 on master.
Comment 4 Philippe "RzR" Coval 2013-06-04 16:09:27 UTC
About this change :

https://git.gnome.org/browse/cheese/commit/?id=bfaafd4b5af9800e6c7425d83aa3b26283659756

shouldnt it merged to gnome-3-8 branch ,

But I think it introduce a small regression :

{

4. Click "Effects" button and choose an effect

Expected result:
5. User may be able to click "Take a Photo" button

Actual result:
5. "Take a photo" button is disabled

Workaround: A user has to click again "Effects" button in order to activate "Take a Photo" button

}


Regards
Comment 5 David King 2013-06-04 16:39:20 UTC
(In reply to comment #4)
> About this change :
> 
> https://git.gnome.org/browse/cheese/commit/?id=bfaafd4b5af9800e6c7425d83aa3b26283659756
> 
> shouldnt it merged to gnome-3-8 branch ,

There is unlikely to be another release from the gnome-3-8 branch, as there are no further 3.8 releases on the schedule, so probably not.

> But I think it introduce a small regression :
> 
> 4. Click "Effects" button and choose an effect
> 
> Expected result:
> 5. User may be able to click "Take a Photo" button
> 
> Actual result:
> 5. "Take a photo" button is disabled
> 
> Workaround: A user has to click again "Effects" button in order to activate
> "Take a Photo" button

There are a several FIXMEs in the code which must be solved to deal with this, so it is not entirely unexpected.