After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700309 - play indicator not centered with respect to title
play indicator not centered with respect to title
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-14 15:30 UTC by William Jon McCann
Modified: 2013-05-16 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (5.49 KB, image/png)
2013-05-14 15:30 UTC, William Jon McCann 		  Details
needs a 1px nudge down (8.74 KB, image/png)
2013-05-14 15:34 UTC, Jakub Steiner 		  Details
the patch fixes the bug. (1.31 KB, patch)
2013-05-16 13:58 UTC, Sai Suman Prayaga 		none Details | Review
image after the patch is applied. (169.55 KB, image/png)
2013-05-16 14:22 UTC, Sai Suman Prayaga 		  Details
nowplaying icon 1 pixel nudge down (1.36 KB, patch)
2013-05-16 15:05 UTC, Vadim Rutkovsky 		committed Details | Review

Description William Jon McCann 2013-05-14 15:30:27 UTC 
Created attachment 244196 [details]
screenshot

The play indicator is not centered with respect to the title.
Comment 1 Jakub Steiner 2013-05-14 15:34:39 UTC 
Created attachment 244198 [details]
needs a 1px nudge down
Comment 2 Sai Suman Prayaga 2013-05-16 13:58:35 UTC 
Created attachment 244407 [details] [review]
the patch fixes the bug.
Comment 3 Sai Suman Prayaga 2013-05-16 14:22:10 UTC 
Created attachment 244409 [details]
image after the patch is applied.

The patch moves down the nowplaying icon by 1px.
Comment 4 Vadim Rutkovsky 2013-05-16 15:05:04 UTC 
The following fix has been pushed:
89536a8 nowplaying icon 1 pixel nudge down
Comment 5 Vadim Rutkovsky 2013-05-16 15:05:07 UTC 
Created attachment 244420 [details] [review]
nowplaying icon 1 pixel nudge down
Comment 6 William Jon McCann 2013-05-16 15:28:46 UTC 
Why not 0.5 for center alignment?
Comment 7 Sai Suman Prayaga 2013-05-16 15:32:35 UTC 
0.5 is the default alignment, which is misaligning the nowplaying icon with the text by a pixel.So it had to be increased to 0.6.
Comment 8 Vadim Rutkovsky 2013-05-16 15:35:00 UTC 
We're using 0.6 alignment because it looks better (0.6 http://postimg.org/image/gqdvcbxvx/ and 0.5 http://postimg.org/image/q3vee8sst/). Using such 'magic number' is potentially harmful. Possibly, alex will help with baseline alignment for cellrenderers