After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700284 - Fix sorting of boxes that were never accessed
Fix sorting of boxes that were never accessed
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-14 11:46 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix sorting of boxes that were never accessed (1.39 KB, patch)
2013-05-14 11:46 UTC, Christophe Fergeau
committed Details | Review

Description Christophe Fergeau 2013-05-14 11:46:26 UTC
Currently, the comparison function only takes into account
access_last_time if it's set for both boxes. If one of them has it
unset, it falls back to using name comparison to sort the boxes.

This means if the user has a box called 'A' and one called 'B', A
having never been used and B being regularly used, A will always
be sorted before B regardless of their access_last_time fields.

This commit ensures that boxes which have their access_last_time field
set are always sorted before the boxes which don't have it set.
Comment 1 Christophe Fergeau 2013-05-14 11:46:28 UTC
Created attachment 244158 [details] [review]
Fix sorting of boxes that were never accessed
Comment 2 Zeeshan Ali 2013-05-14 12:20:41 UTC
Review of attachment 244158 [details] [review]:

ACK. I saw something fishy in sorting but never got to investigate it. Hopefully this is the same issue I saw.
Comment 3 Christophe Fergeau 2013-05-15 09:43:03 UTC
Attachment 244158 [details] pushed as 871a958 - Fix sorting of boxes that were never accessed