GNOME Bugzilla – Bug 700276
lastfm: update to new API 2.0
Last modified: 2015-09-14 16:20:36 UTC
Lastfm API has moved to a new version. We should update lastfm-albumart plugin to use the new version.
Old API has been deprecated, 'get_thumbnail' returns None now
Created attachment 310595 [details] [review] lastfm-albumart: update to lastfm api 2.0 Last.FM API 1.0 stopped working, forcing us to use the new Scrobbling API. This patch updates the lastfm-albumart plugin to use the new Scrobbling API.
Review of attachment 310595 [details] [review]: The tests in tests/lastfm-albumart also need updating. Run "make check" in that directory to double-check your changes.
Created attachment 311070 [details] [review] lastfm-albumart: update to lastfm api 2.0 Last.FM API 1.0 stopped working, forcing us to use the new Scrobbling API. This patch fixes it by introducing the new Last.FM Scrobbling API. Consequently, it now requires an API key to be given. It is up to the consumer application to pass it through GrlConfig.
Created attachment 311085 [details] [review] lua-factory: Add Last.fm plugin
Created attachment 311092 [details] [review] lastfm-albumart: Remove C version of the Last.fm plugin It was using an outdated API, and has now been fixed and ported to Lua, using gnome-online-accounts support. This leaves the tests alone, as they will be repurposed.
Created attachment 311093 [details] [review] tests: Port lastfm-albumart test to test spotify-cover Repurpose the tests to cover the Spotify cover plugin instead of the last.fm one, as the last.fm plugin now requires GOA to be instantiated.
Comment on attachment 311070 [details] [review] lastfm-albumart: update to lastfm api 2.0 We won't be using this plugin in the future, as we prefer to require gnome-online-accounts rather than applications providing the API key. So reject this patch which requires applications to be updated, and use the older patch instead.
Comment on attachment 310595 [details] [review] lastfm-albumart: update to lastfm api 2.0 Will commit this after a few fixes.
Comment on attachment 310595 [details] [review] lastfm-albumart: update to lastfm api 2.0 Fixed in 0.2.x for GNOME 3.16/3.18.
Attachment 311085 [details] pushed as 688024e - lua-factory: Add Last.fm plugin Attachment 311092 [details] pushed as 37bacc5 - lastfm-albumart: Remove C version of the Last.fm plugin Attachment 311093 [details] pushed as 6dc67fa - tests: Port lastfm-albumart test to test spotify-cover