After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700219 - dnsmasq path not configurable
dnsmasq path not configurable
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-13 10:44 UTC by Jan Alexander Steffens (heftig)
Modified: 2014-01-03 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch adding --with-dnsmasq (3.09 KB, patch)
2013-05-13 11:10 UTC, Jan Alexander Steffens (heftig) 		reviewed Details | Review
build: add --with-dnsmasq, to specify dnsmasq path (2.61 KB, patch)
2014-01-02 20:52 UTC, Dan Winship 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2013-05-13 10:44:38 UTC 
The paths of other binaries like iptables are configurable via:
  --with-iptables=/usr/bin/iptables

This is not the case for dnsmasq, necessitating patching in order to support a non-sbin path.
Comment 1 Jan Alexander Steffens (heftig) 2013-05-13 11:10:58 UTC 
Created attachment 243976 [details] [review]
patch adding --with-dnsmasq

Here's a naive patch adding --with-dnsmasq support.

I would probably be happiest if NetworkManager would just use the PATH to find any binary it needs (that's not known to reside in libexec).
Comment 2 Dan Williams 2013-05-13 18:27:56 UTC 
Review of attachment 243976 [details] [review]:

Instead of "strlen (try_first)" let's just use:

if (try_first && try_first[0] && g_file_test...)

Other than that, looks fine.
Comment 3 Dan Winship 2014-01-02 20:52:09 UTC 
Created attachment 265188 [details] [review]
build: add --with-dnsmasq, to specify dnsmasq path

simplified version...
Comment 4 Thomas Haller 2014-01-03 00:55:25 UTC 
(In reply to comment #3)
> Created an attachment (id=265188) [details] [review]
> build: add --with-dnsmasq, to specify dnsmasq path
> 
> simplified version...

I think, this is good. ACK
Comment 5 Dan Winship 2014-01-03 19:51:28 UTC 
Attachment 265188 [details] pushed as 691422a - build: add --with-dnsmasq, to specify dnsmasq path