GNOME Bugzilla – Bug 700190
Removable Devices' right-click triggers JS errors, disables context menu
Last modified: 2013-06-08 08:52:04 UTC
Created attachment 243931 [details] Video showing triggering of JS backtrace Right clicking "Removable Devices" on Message Tray and hovering the list with the mouse triggers JS errors. Context menu, with left or right click, will then stop working until gnome-shell is restarted. Version: gnome-shell-3.8.1-4.fc19.i686 ----------------- Video attached. ----------------- Description of steps made in video: 1. Windows+M, left click, hovering of list does nothing to the console in background. 2. Windows+M, right click, hovering of list triggers JS errors. 3. Windows+M, left and right click do nothing. 4. Right-clicking on Dropbox works (clicked just to be sure). DO NOTE: due to bug #692706 I'm running a custom clutter (clutter+20 line patch on cally_stage_notify_key_focus_cb), but I've tried with old clutter and problem persists. If needed I can test again with old clutter. ----------------- JS below: ----------------- $ Recording to ~/Screencast from 12-05-2013 17:43:08.webm JS ERROR: !!! Exception was: TypeError: this._summaryBoxPointerItem is null JS ERROR: !!! message = '"this._summaryBoxPointerItem is null"' JS ERROR: !!! fileName = '"/usr/share/gnome-shell/js/ui/messageTray.js"' JS ERROR: !!! lineNumber = '2646' JS ERROR: !!! stack = '"()@/usr/share/gnome-shell/js/ui/messageTray.js:2646 wrapper()@/usr/share/gjs-1.0/lang.js:213 ()@/usr/share/gnome-shell/js/ui/messageTray.js:2263 wrapper()@/usr/share/gjs-1.0/lang.js:213 ()@/usr/share/gnome-shell/js/ui/messageTray.js:2187 wrapper()@/usr/share/gjs-1.0/lang.js:213 "' JS ERROR: !!! Error calling onComplete JS ERROR: !!! message = '"this._summaryBoxPointerItem is null"' JS ERROR: !!! fileName = '"/usr/share/gnome-shell/js/ui/messageTray.js"' JS ERROR: !!! lineNumber = '2780' JS ERROR: !!! stack = '"()@/usr/share/gnome-shell/js/ui/messageTray.js:2780 wrapper()@/usr/share/gjs-1.0/lang.js:213 ()@/usr/share/gnome-shell/js/ui/boxpointer.js:157 ()@/usr/share/gnome-shell/js/ui/tweener.js:113 _callOnFunction((function () {oldHandler.apply(eventScope, oldParams);handler(target);}),"onComplete",(void 0),[object Object],(void 0))@/usr/share/gjs-1.0/tweener/tweener.js:202 _updateTweenByIndex(0)@/usr/share/gjs-1.0/tweener/tweener.js:332 _updateTweens()@/usr/share/gjs-1.0/tweener/tweener.js:344 _onEnterFrame([object Object])@/usr/share/gjs-1.0/tweener/tweener.js:359 _emit("prepare-frame")@/usr/share/gjs-1.0/signals.js:124 (220)@/usr/share/gnome-shell/js/ui/tweener.js:253 wrapper(220)@/usr/share/gjs-1.0/lang.js:213 ([object GObject_Object],220)@/usr/share/gnome-shell/js/ui/tweener.js:228 "'
Using JHbuild's gnome-shell I have the same error/behaviour. $ jhbuild run gnome-shell --version GNOME Shell 3.8.2
I can confirm this behaviour, tested on F19 with gnome-shell-3.8.2-3.fc19.x86_64
Created attachment 245260 [details] [review] messageTray: Check if the clicked summary item has a right click menu Commit e71129aa6879b62a04d2fc3b43ff25edd6611987 introduced the possibility of having summary items without a right click menu so we should check for one before trying to show it. -- I haven't tried to reproduce on master yet, but this fixes it for me on 3.8. I also added a few more checks to be sure that we don't access properties on a potentially null variable there.
DimStar on #opensuse-gnome found that the issue is fixed in master by commit 1b135095
Review of attachment 245260 [details] [review]: OK.
Attachment 245260 [details] pushed as 2eb7797 - messageTray: Check if the clicked summary item has a right click menu
*** Bug 700538 has been marked as a duplicate of this bug. ***