After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700158 - Implement seek preview
Implement seek preview
Status: RESOLVED DUPLICATE of bug 586982
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-12 10:37 UTC by Lionel Landwerlin
Modified: 2014-01-24 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backend: set size request instead of get_preferred vfuncs (2.27 KB, patch)
2013-05-12 10:37 UTC, Lionel Landwerlin
reviewed Details | Review
main: implement seek preview (5.69 KB, patch)
2013-05-12 10:37 UTC, Lionel Landwerlin
none Details | Review

Description Lionel Landwerlin 2013-05-12 10:37:01 UTC
Kind of like what you get on youtube. This is a proof of concept, there is still a bit of logic to add to prevent the preview from happening on a stream or a non seekable content, etc...

I would like to know what people think :)
Comment 1 Lionel Landwerlin 2013-05-12 10:37:28 UTC
Created attachment 243894 [details] [review]
backend: set size request instead of get_preferred vfuncs
Comment 2 Lionel Landwerlin 2013-05-12 10:37:54 UTC
Created attachment 243895 [details] [review]
main: implement seek preview
Comment 3 Bastien Nocera 2013-05-13 09:12:10 UTC
Review of attachment 243894 [details] [review]:

Why?
Comment 4 Bastien Nocera 2013-05-13 09:20:07 UTC
This is interesting (we actually have another bug opened about something similar, see bug 586982), but I think it should be implemented in the backend instead, and reuse a single video widget. Otherwise we just end up loading the file twice.
Comment 5 Lionel Landwerlin 2013-05-13 09:32:34 UTC
Review of attachment 243894 [details] [review]:

To allow the bacon widget to have different minimal sizes.
Comment 6 Lionel Landwerlin 2013-05-13 09:35:58 UTC
Yeah, I don't really see how to do this with a single pipeline... Give that the preview is going to seek at different places.
That's why I had in mind to only enable this for local files, other it could trigger a lot of traffic for remote files.
Comment 7 Bastien Nocera 2014-01-24 08:40:30 UTC
I'll mark this as a dupe of bug 586982, and ask for designer input. We might go for something in between the 2 solutions in the end.

*** This bug has been marked as a duplicate of bug 586982 ***