After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700149 - gnome-control-center 3.8.x and trunk. Please do not make the integration of GNOME on source based distributions from hard to impossible
gnome-control-center 3.8.x and trunk. Please do not make the integration of G...
Status: RESOLVED DUPLICATE of bug 700145
Product: gnome-control-center
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-12 09:11 UTC by Evgeny Bobkin
Modified: 2013-05-13 07:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch proposal (9.35 KB, patch)
2013-05-12 09:24 UTC, Evgeny Bobkin
rejected Details | Review
patch proposal for optional kerberos support (6.51 KB, patch)
2013-05-12 09:25 UTC, Evgeny Bobkin
rejected Details | Review
patch proposal for optional modemmanager support (1.06 KB, patch)
2013-05-12 09:26 UTC, Evgeny Bobkin
rejected Details | Review

Description Evgeny Bobkin 2013-05-12 09:11:44 UTC
This bug is about automatic dependences used in gnome-control-center's configure.ac file.

Please use either mandatory dependencies and optional dependencies only.
The prefered way for the source based distributions is to deal with optional dependencies.

The automatic dependencies on the other side are evil! A more detailed explanation can be found here: http://www.gentoo.org/proj/en/qa/automagic.xml

Here is an example of automatic dependence from the configure.ac file:

# Check for libmm-glib for ModemManager1 support
PKG_CHECK_MODULES(MM_GLIB, mm-glib,
                  [have_libmm_glib=yes], have_libmm_glib=no)
if test "x$have_libmm_glib" = xno ; then
  AC_MSG_WARN(*** Network panel will not be built with ModemManager1 support (libmm-glib not found) ***)
else
  AC_DEFINE(HAVE_MM_GLIB, 1, [Defined if libmm-glib is available])
fi
AM_CONDITIONAL(HAVE_MM_GLIB, test "x$have_libmm_glib" = "xyes")

For now the issues regarding the stabilization of the modemmanager (https://bugzilla.gnome.org/show_bug.cgi?id=688238#c24 also on binary-based distributions https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1123302), combined with the automatic dependencies issues turned into in one of the BLOCKERS, which makes the integration of GNOME 3.8.x especially on gentoo very hard. Therefore, this is one of the reasons, why GNOME 3.8 is hard masked on gentoo.

Based on the above said, please do not make the dependency on modemmanager mandatory!!!
Comment 1 Evgeny Bobkin 2013-05-12 09:24:57 UTC
Created attachment 243885 [details] [review]
patch proposal
Comment 2 Evgeny Bobkin 2013-05-12 09:25:54 UTC
Created attachment 243886 [details] [review]
patch proposal for optional kerberos support
Comment 3 Evgeny Bobkin 2013-05-12 09:26:56 UTC
Created attachment 243887 [details] [review]
patch proposal for optional modemmanager support
Comment 4 Bastien Nocera 2013-05-13 07:08:14 UTC
Review of attachment 243885 [details] [review]:

Absolutely not. The only optional dependencies are optional on non-Linux, so the package can keep on building on FreeBSD for example.

Making those optional is not planned, or wanted.
Comment 5 Bastien Nocera 2013-05-13 07:08:49 UTC
Review of attachment 243886 [details] [review]:

Kerberos support is not optional, as mentioned above.
Comment 6 Bastien Nocera 2013-05-13 07:09:26 UTC
Review of attachment 243887 [details] [review]:

ModemManager should be a hard requirement on platforms where it is available (eg. Linux).
Comment 7 Bastien Nocera 2013-05-13 07:13:38 UTC
gnome-control-center isn't a bag of bits where you can pick and choose which part of the OS you choose to build.
I'm not interested in debugging why it was built without Bluetooth support on such and such distribution because the packager didn't see the need for it. Same goes for color, Kerberos support, support for 3G modems, wacom tablets, or online accounts.

I'm leaving this open if you want to provide a patch to make ModemManager a requirement on platforms where NetworkManager is available.
Comment 8 Bastien Nocera 2013-05-13 07:20:39 UTC
Actually, I see that bug 700145 is about ModemManager's configure checks already.

*** This bug has been marked as a duplicate of bug 700145 ***