GNOME Bugzilla – Bug 700045
gitg: off-by-one in line numbering of diff in "Changes" tab
Last modified: 2013-06-14 17:11:42 UTC
Forwarding Debian bug #693430: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693430 A typical content of the "Changes" tab looks like this in ascii art: diff --git a/foo b/foo index abcde..12345 100644 3 5 @@ -3,8 +5,7 @@ context 4 6 common context 5 7 common context 6 common context 7 -line only in a/foo 8 -line only in a/foo 8 9 +line only in b/foo 9 10 common context 10 11 common context 11 12 common context 12 13 Please observe how the @@ line is already numbered. It should have no numbers instead. As a consequence the last "common context" line is numbered as the first deleted line. Also notice how there is an empty line numbered. This seems like a wrong fix to the wrong numbering. The corresponding code is in gitg-diff-view.c function ensure_scan, but I have no idea how to fix this.
Hello, Dmitry, > A typical content of the "Changes" tab looks like this in ascii art: > > diff --git a/foo b/foo > index abcde..12345 100644 > 3 5 @@ -3,8 +5,7 @@ context <snip> > Please observe how the @@ line is already numbered. It should have no > numbers instead. Am reporting that @@ line is no more numbered in the diff view (the part of gitg where a commit's details are shown) in the current git master code and hence all other repercussion as a result are also fixed. Please confirm if this bug could be closed.
Created attachment 243804 [details] Screenshot showing the newer diff view
This bug report was filed against an older version of gitg (C-version). Moving bug to gitg-0.x. As per previous comments, the bug is no longer reproducible against the current git master version of gitg (written in vala). Closing bug as RESOLVED and OBSOLETE.