After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700038 - rfbsrc: port to 1.0
rfbsrc: port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.0.7
Other Linux
: Normal enhancement
: 1.0.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-09 23:43 UTC by Aleix Conchillo Flaqué
Modified: 2013-05-10 23:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rfbsrc ported to gstreamer 1.0 (13.08 KB, patch)
2013-05-09 23:45 UTC, Aleix Conchillo Flaqué
committed Details | Review
rfbsrc gio porting (10.76 KB, patch)
2013-05-10 16:52 UTC, Aleix Conchillo Flaqué
committed Details | Review

Description Aleix Conchillo Flaqué 2013-05-09 23:43:20 UTC
rfbsrc still not ported to GStreamer 1.0.
Comment 1 Aleix Conchillo Flaqué 2013-05-09 23:45:39 UTC
Created attachment 243750 [details] [review]
rfbsrc ported to gstreamer 1.0

Initial port of librfb to GStreamer 1.0. Seems to work fine so far.
Comment 2 Tim-Philipp Müller 2013-05-10 10:35:40 UTC
Nice! Any chance you could also port the networking code over to GLib's (gio) networking stack? Shouldn't be much work hopefully, but it helps with portability.
Comment 3 Aleix Conchillo Flaqué 2013-05-10 14:31:09 UTC
I'll have a look.
Comment 4 Aleix Conchillo Flaqué 2013-05-10 16:52:11 UTC
Created attachment 243806 [details] [review]
rfbsrc gio porting

This is a second patch with the gio support. It seems to work too, but I haven't tried it on other platforms, but Linux.
Comment 5 Tim-Philipp Müller 2013-05-10 17:00:47 UTC
Brilliant, thanks a lot. Will have a look at it later.
Comment 6 Aleix Conchillo Flaqué 2013-05-10 18:44:40 UTC
Great. Let me know if there's anything you'd like me to change.
Comment 7 Tim-Philipp Müller 2013-05-10 23:04:31 UTC
Looks good, thanks!


commit 0fc4af84980c7b76c67357f99ac2e2c5edbdbc5d
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Fri May 10 23:09:30 2013 +0100

    rfbsrc: remove GPL-licensed source file
    
    and replace the 1% of it that we need with new code, so we
    don't have to change the runtime license of rfbsrc to GPL.

commit 90e006513adf760190a8d0032473785cac67dad7
Author: Aleix Conchillo Flaque <aleix@oblong.com>
Date:   Fri May 10 09:49:46 2013 -0700

    rfbsrc: use glib gio sockets for network access
    
    https://bugzilla.gnome.org/show_bug.cgi?id=700038

commit 42783e676e34de906491df97bc13012766d7d108
Author: Aleix Conchillo Flaque <aleix@oblong.com>
Date:   Thu May 9 16:41:32 2013 -0700

    rfbsrc: port to 1.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=700038
Comment 8 Tim-Philipp Müller 2013-05-10 23:05:56 UTC
Only changed some minor things (skipped spaces-at-end-of-line chunks in configure.ac, some Makefile.am changes).
Comment 9 Tim-Philipp Müller 2013-05-10 23:06:27 UTC
Oh, and removed the WSAStartup/Cleanup leftovers.
Comment 10 Aleix Conchillo Flaqué 2013-05-10 23:21:11 UTC
Fantastic. Thank you!