GNOME Bugzilla – Bug 700038
rfbsrc: port to 1.0
Last modified: 2013-05-10 23:21:11 UTC
rfbsrc still not ported to GStreamer 1.0.
Created attachment 243750 [details] [review] rfbsrc ported to gstreamer 1.0 Initial port of librfb to GStreamer 1.0. Seems to work fine so far.
Nice! Any chance you could also port the networking code over to GLib's (gio) networking stack? Shouldn't be much work hopefully, but it helps with portability.
I'll have a look.
Created attachment 243806 [details] [review] rfbsrc gio porting This is a second patch with the gio support. It seems to work too, but I haven't tried it on other platforms, but Linux.
Brilliant, thanks a lot. Will have a look at it later.
Great. Let me know if there's anything you'd like me to change.
Looks good, thanks! commit 0fc4af84980c7b76c67357f99ac2e2c5edbdbc5d Author: Tim-Philipp Müller <tim@centricular.net> Date: Fri May 10 23:09:30 2013 +0100 rfbsrc: remove GPL-licensed source file and replace the 1% of it that we need with new code, so we don't have to change the runtime license of rfbsrc to GPL. commit 90e006513adf760190a8d0032473785cac67dad7 Author: Aleix Conchillo Flaque <aleix@oblong.com> Date: Fri May 10 09:49:46 2013 -0700 rfbsrc: use glib gio sockets for network access https://bugzilla.gnome.org/show_bug.cgi?id=700038 commit 42783e676e34de906491df97bc13012766d7d108 Author: Aleix Conchillo Flaque <aleix@oblong.com> Date: Thu May 9 16:41:32 2013 -0700 rfbsrc: port to 1.0 https://bugzilla.gnome.org/show_bug.cgi?id=700038
Only changed some minor things (skipped spaces-at-end-of-line chunks in configure.ac, some Makefile.am changes).
Oh, and removed the WSAStartup/Cleanup leftovers.
Fantastic. Thank you!