After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700033 - tests: New runtime check force unit tests to send initial events
tests: New runtime check force unit tests to send initial events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-09 20:50 UTC by Nicolas Dufresne (ndufresne)
Modified: 2013-05-11 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] check: Add helper that sends initial events (3.18 KB, patch)
2013-05-09 21:18 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] wavpackdec-test: Send initial events (2.09 KB, patch)
2013-05-09 21:20 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] vp8dec-test: Send inital events (923 bytes, patch)
2013-05-09 21:21 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] vp8enc-test: Send inital events (932 bytes, patch)
2013-05-09 21:49 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] jpegenc-test: Send inital events (1.06 KB, patch)
2013-05-09 22:05 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] y4menc-test: Send inital events (968 bytes, patch)
2013-05-10 13:24 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] wavpackparse-test: Send inital events (865 bytes, patch)
2013-05-10 13:24 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] videofilter-test: Send inital events (961 bytes, patch)
2013-05-10 13:24 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] spectrum-test: Send inital events (4.65 KB, patch)
2013-05-10 13:24 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] shapewipe-test: Send inital events (4.12 KB, patch)
2013-05-10 13:25 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2013-05-09 20:50:26 UTC
With the new runtime check, events stream-start and segment must be sent before any data flow, tests that wraps a single element are now forced to send these event before data flow.

As this is always the same over and over I have started by adding a new helper to gstcheck library, patches coming ...
Comment 1 Nicolas Dufresne (ndufresne) 2013-05-09 21:18:11 UTC
Created attachment 243737 [details] [review]
[PATCH] check: Add helper that sends initial events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 docs/libs/gstreamer-libs-sections.txt |  1 +
 libs/gst/check/Makefile.am            |  1 +
 libs/gst/check/gstcheck.c             | 29 +++++++++++++++++++++++++++++
 libs/gst/check/gstcheck.h             |  2 ++
 4 files changed, 33 insertions(+)
Comment 2 Nicolas Dufresne (ndufresne) 2013-05-09 21:20:57 UTC
Created attachment 243738 [details] [review]
[PATCH] wavpackdec-test: Send initial events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/wavpackdec.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)
Comment 3 Nicolas Dufresne (ndufresne) 2013-05-09 21:21:00 UTC
Created attachment 243739 [details] [review]
[PATCH] vp8dec-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/vp8dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Nicolas Dufresne (ndufresne) 2013-05-09 21:49:20 UTC
Created attachment 243742 [details] [review]
[PATCH] vp8enc-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/vp8enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Nicolas Dufresne (ndufresne) 2013-05-09 22:05:22 UTC
Created attachment 243745 [details] [review]
[PATCH] jpegenc-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/jpegenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Sebastian Dröge (slomo) 2013-05-10 07:25:22 UTC
All pushed
Comment 7 Nicolas Dufresne (ndufresne) 2013-05-10 13:23:53 UTC
Re-opening as there is more to come (still 40 tests to look at in good and about the same in -base).
Comment 8 Nicolas Dufresne (ndufresne) 2013-05-10 13:24:48 UTC
Created attachment 243777 [details] [review]
[PATCH] y4menc-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/y4menc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Nicolas Dufresne (ndufresne) 2013-05-10 13:24:52 UTC
Created attachment 243778 [details] [review]
[PATCH] wavpackparse-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/wavpackparse.c | 1 +
 1 file changed, 1 insertion(+)
Comment 10 Nicolas Dufresne (ndufresne) 2013-05-10 13:24:55 UTC
Created attachment 243779 [details] [review]
[PATCH] videofilter-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/videofilter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 Nicolas Dufresne (ndufresne) 2013-05-10 13:24:58 UTC
Created attachment 243780 [details] [review]
[PATCH] spectrum-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/spectrum.c | 35 ++++++++++-------------------------
 1 file changed, 10 insertions(+), 25 deletions(-)
Comment 12 Nicolas Dufresne (ndufresne) 2013-05-10 13:25:01 UTC
Created attachment 243781 [details] [review]
[PATCH] shapewipe-test: Send inital events


https://bugzilla.gnome.org/show_bug.cgi?id=700033
---
 tests/check/elements/shapewipe.c | 38 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 21 deletions(-)