After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700005 - Don't disable deprecated API by default
Don't disable deprecated API by default
Status: RESOLVED FIXED
Product: frogr
Classification: Other
Component: general
master
Other All
: Normal normal
: ---
Assigned To: frogr maintainers
frogr maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-09 12:19 UTC by Alberto Garcia
Modified: 2013-09-04 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (815 bytes, patch)
2013-05-09 12:19 UTC, Alberto Garcia 		none Details | Review
Disable only when compiling with --enable-debug (1.28 KB, patch)
2013-09-03 18:33 UTC, Alberto Garcia 		accepted-commit_now Details | Review

Description Alberto Garcia 2013-05-09 12:19:00 UTC 
Deprecated API is disable in configure.ac, however there's no
configure options to change that.

While this is useful for removing all the deprecated API from your
code, it's not a good idea to have it enabled by default, particularly
in releases.

With this you're making builds fail in cases where they would
otherwise work.

See http://bugs.debian.org/707379 for an example.
Comment 1 Alberto Garcia 2013-05-09 12:19:44 UTC 
Created attachment 243688 [details] [review]
Patch
Comment 2 Mario Sánchez Prada 2013-05-13 21:27:13 UTC 
Thanks for the patch, I also think it's a good idea to fix this. However, instead of just removing those flags right away, I'd rather keep them for debug builds at leas, which is the ones that I use all the time for development.
Comment 3 Alberto Garcia 2013-05-13 21:33:39 UTC 
Sure, as long as it's configurable I think it's fine.
Comment 4 Mario Sánchez Prada 2013-08-30 23:05:28 UTC 
I've just come across this bug while checking which open bugs frogr had and was wondering whether you are still interested in committing this change.

If you are not, I will probably just add that line you are removing from release builds, but wanted to double check first with you in case you preferred any other option (e.g. adding a parameter to configure)
Comment 5 Alberto Garcia 2013-09-01 09:33:46 UTC 
As long as they're not enabled by default I think I'm fine with any option.
Comment 6 Alberto Garcia 2013-09-03 18:33:39 UTC 
Created attachment 254011 [details] [review]
Disable only when compiling with --enable-debug

Here's an alternative patch that enables those settings in debug mode only.
Comment 7 Mario Sánchez Prada 2013-09-04 09:36:20 UTC 
Comment on attachment 254011 [details] [review]
Disable only when compiling with --enable-debug

(In reply to comment #6)
> Created an attachment (id=254011) [details] [review]
> Disable only when compiling with --enable-debug
> 
> Here's an alternative patch that enables those settings in debug mode only.

Cool. Please feel free to commit it and resolve this bug when you want.

Thanks!