After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700003 - [PATCH] Include string.h in soup-request-file.c
[PATCH] Include string.h in soup-request-file.c
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.43.x
Other Windows
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-09 11:50 UTC by Erik van Pienbroek
Modified: 2013-05-09 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (707 bytes, patch)
2013-05-09 11:50 UTC, Erik van Pienbroek
committed Details | Review

Description Erik van Pienbroek 2013-05-09 11:50:25 UTC
Created attachment 243684 [details] [review]
Proposed patch

Resolves implicit declaration failures of functions like 'strchr'

==

  CC       soup-request-file.lo
../../libsoup/soup-request-file.c: In function 'windowsify_file_uri_path':
../../libsoup/soup-request-file.c:98:2: error: implicit declaration of function 'strchr' [-Werror=implicit-function-declaration]
  while ((slash = strchr (p, '/')) != NULL) {
  ^
../../libsoup/soup-request-file.c:98:18: warning: incompatible implicit declaration of built-in function 'strchr' [enabled by default]
  while ((slash = strchr (p, '/')) != NULL) {
                  ^
../../libsoup/soup-request-file.c:112:4: error: implicit declaration of function 'memmove' [-Werror=implicit-function-declaration]
    memmove (path, path + 1, strlen (path));
    ^
../../libsoup/soup-request-file.c:112:4: warning: incompatible implicit declaration of built-in function 'memmove' [enabled by default]
../../libsoup/soup-request-file.c:112:4: error: implicit declaration of function 'strlen' [-Werror=implicit-function-declaration]
../../libsoup/soup-request-file.c:112:29: warning: incompatible implicit declaration of built-in function 'strlen' [enabled by default]
    memmove (path, path + 1, strlen (path));
                             ^
cc1: some warnings being treated as errors
make[3]: *** [soup-request-file.lo] Error 1
Comment 1 Dan Winship 2013-05-09 13:15:33 UTC
thanks