After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699968 - capsfilter: Send caps after segment if source has no caps
capsfilter: Send caps after segment if source has no caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-09 00:16 UTC by Nicolas Dufresne (ndufresne)
Modified: 2013-05-09 07:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] capsfilter: Send caps before segment (3.99 KB, patch)
2013-05-09 01:45 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
[PATCH] capsfilter: Send caps before segment (5.13 KB, patch)
2013-05-09 03:34 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2013-05-09 00:16:29 UTC
The caps filter element will send caps after segment if source has no caps. Pipepline to reporduce:

gst-launch fakesrc num-buffers=1 format=time ! capsfilter caps=video/h264 ! fakesink

Currently, it will negotiate on first buffer, but maybe it should negotiate when the segment comes in.
Comment 1 Nicolas Dufresne (ndufresne) 2013-05-09 01:45:56 UTC
Created attachment 243659 [details] [review]
[PATCH] capsfilter: Send caps before segment


In the case the source has no caps, caps must be sent before segment. This
fixes few unit tests that where failing due to the new misordering warning.

https://bugzilla.gnome.org/show_bug.cgi?id=699968
---
 plugins/elements/gstcapsfilter.c | 43 +++++++++++++++++++++++++++++-----------
 1 file changed, 31 insertions(+), 12 deletions(-)
Comment 2 Nicolas Dufresne (ndufresne) 2013-05-09 01:48:04 UTC
This also makes all tests pass again in gstreamer core
Comment 3 Nicolas Dufresne (ndufresne) 2013-05-09 01:49:15 UTC
Comment on attachment 243659 [details] [review]
[PATCH] capsfilter: Send caps before segment

(In reply to comment #2)
> This also makes all tests pass again in gstreamer core

Forget that, it failed on second try.
Comment 4 Nicolas Dufresne (ndufresne) 2013-05-09 03:34:34 UTC
Created attachment 243670 [details] [review]
[PATCH] capsfilter: Send caps before segment


In the case the source has no caps, caps must be sent before segment. This
fixes few unit tests that where failing due to the new misordering warning.

https://bugzilla.gnome.org/show_bug.cgi?id=699968
---
 plugins/elements/gstcapsfilter.c | 49 ++++++++++++++++++++++++++++++++++------
 plugins/elements/gstcapsfilter.h |  1 +
 2 files changed, 43 insertions(+), 7 deletions(-)
Comment 5 Sebastian Dröge (slomo) 2013-05-09 07:33:25 UTC
commit 98f6b75cd3ed0f1b49425c534759e69bf831054e
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu May 9 09:32:49 2013 +0200

    capsfilter: Send all events that should happen after CAPS after the CAPS event

commit c86f42bc88778d4638eff7428075893e7af2a62a
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Wed May 8 21:45:08 2013 -0400

    capsfilter: Send caps before segment
    
    In the case the source has no caps, caps must be sent before segment. This
    fixes few unit tests that where failing due to the new misordering warning.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699968