After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699966 - tests: Some unit test in good sends SEGMENT before caps
tests: Some unit test in good sends SEGMENT before caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-08 22:56 UTC by Nicolas Dufresne (ndufresne)
Modified: 2013-05-09 07:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] audiowsinclimit: Test should send segment after CAPS (8.87 KB, patch)
2013-05-08 23:01 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] audiowsincband: Test should send segment after CAPS (11.30 KB, patch)
2013-05-08 23:08 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] avimux: Unit test sends SEGMENT before caps (1.39 KB, patch)
2013-05-08 23:22 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review
[PATCH] videofilter: Unit test send CAPS before segment (1.14 KB, patch)
2013-05-08 23:54 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
[PATCH] videofilter: Unit test send SEGMENT before CAPS (1.14 KB, patch)
2013-05-08 23:56 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2013-05-08 22:56:14 UTC
After the additions of a warning for mis-ordered sticky event, audiowsinclimit test won't pass. In this case it seems that the test is broken (patch coming).
Comment 1 Nicolas Dufresne (ndufresne) 2013-05-08 23:01:13 UTC
Created attachment 243640 [details] [review]
[PATCH] audiowsinclimit: Test should send segment after CAPS


This makes the unit test pass again.

https://bugzilla.gnome.org/show_bug.cgi?id=699966
---
 tests/check/elements/audiowsinclimit.c | 80 +++++++++++++++++-----------------
 1 file changed, 40 insertions(+), 40 deletions(-)
Comment 2 Nicolas Dufresne (ndufresne) 2013-05-08 23:04:18 UTC
More patches coming
Comment 3 Nicolas Dufresne (ndufresne) 2013-05-08 23:08:53 UTC
Created attachment 243641 [details] [review]
[PATCH] audiowsincband: Test should send segment after CAPS


This makes the unit test pass again.

https://bugzilla.gnome.org/show_bug.cgi?id=699966
---
 tests/check/elements/audiowsincband.c | 104 +++++++++++++++++-----------------
 1 file changed, 52 insertions(+), 52 deletions(-)
Comment 4 Nicolas Dufresne (ndufresne) 2013-05-08 23:09:39 UTC
I'm done for audiofx
Comment 5 Nicolas Dufresne (ndufresne) 2013-05-08 23:22:53 UTC
Created attachment 243644 [details] [review]
[PATCH] avimux: Unit test sends SEGMENT before caps


https://bugzilla.gnome.org/show_bug.cgi?id=699966
---
 tests/check/elements/avimux.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Comment 6 Nicolas Dufresne (ndufresne) 2013-05-08 23:54:46 UTC
Created attachment 243646 [details] [review]
[PATCH] videofilter: Unit test send CAPS before segment


https://bugzilla.gnome.org/show_bug.cgi?id=699966
---
 tests/check/elements/videofilter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 7 Nicolas Dufresne (ndufresne) 2013-05-08 23:56:00 UTC
Created attachment 243647 [details] [review]
[PATCH] videofilter: Unit test send SEGMENT before CAPS


https://bugzilla.gnome.org/show_bug.cgi?id=699966
---
 tests/check/elements/videofilter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 8 Sebastian Dröge (slomo) 2013-05-09 07:08:34 UTC
commit 8a9a3039fc2d19a7e36deae091b855eff63d9eb6
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Wed May 8 19:54:19 2013 -0400

    videofilter: Unit test send SEGMENT before CAPS
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699966

commit 43f9934ba51e38e1655b45ced60d2746c9ad6732
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Wed May 8 19:22:31 2013 -0400

    avimux: Unit test sends SEGMENT before caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699966

commit 9bd526ef4a15b65b2ca685a4fafc7eee4956510f
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Wed May 8 19:08:24 2013 -0400

    audiowsincband: Test should send segment after CAPS
    
    This makes the unit test pass again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699966

commit 22d64ea3be9369cbf31d57ba0bda1984c23c0fbb
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Wed May 8 19:00:28 2013 -0400

    audiowsinclimit: Test should send segment after CAPS
    
    This makes the unit test pass again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699966