After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699960 - videodecoder: Reordering sticky events
videodecoder: Reordering sticky events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-08 22:03 UTC by Mathieu Duponchelle
Modified: 2013-05-10 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch to fix the issue (3.73 KB, patch)
2013-05-08 22:04 UTC, Mathieu Duponchelle 		rejected Details | Review
Patch to really send stored events. (793 bytes, patch)
2013-05-09 21:33 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2013-05-08 22:03:23 UTC 
There's been a first patch by slomo earlier today, but there still are events being sent too soon by _prepare_finish_frame. The proposed patch stores them for sending in the negotiate_default.

A point of interrogation for me is : do we want to reset has_set_caps in reset or only in reset when full is True ?
Comment 1 Mathieu Duponchelle 2013-05-08 22:04:47 UTC 
Created attachment 243631 [details] [review]
Proposed patch to fix the issue
Comment 2 Mathieu Duponchelle 2013-05-08 22:08:58 UTC 
example faulty pipeline by the way : 
gst-launch-1.0 filesrc location="~/Videos/any.ogv" ! oggdemux ! theoradec ! autovideosink
Comment 3 Sebastian Dröge (slomo) 2013-05-09 14:09:33 UTC 
Solved differently and more generic:

commit 2cc6a62b315ad5eb64305574a87b0fbbd7033a48
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu May 9 15:42:49 2013 +0200

    videoencoder: Make sure to push any pre-caps events before the caps are set

commit 82f1572205dbc86ebefc52029ef5e4c221c275da
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu May 9 15:34:10 2013 +0200

    videodecoder: Make sure to not push any post-caps events before we have caps
    
    and that we push pre-caps events before we push caps, even if we don't
    have a GstVideoFrame yet.
Comment 4 Mathieu Duponchelle 2013-05-09 21:33:54 UTC 
Created attachment 243740 [details] [review]
Patch to really send stored events.

That patch is quite self-explanatory :)
Comment 5 Sebastian Dröge (slomo) 2013-05-10 07:22:26 UTC 
commit 6f233f67efa338a52a4f5c439f3c47ebc9431b4c
Author: Mathieu Duponchelle <mathieu.duponchelle@epitech.eu>
Date:   Thu May 9 23:30:33 2013 +0200

    videodecoder: don't set the list to NULL after taking its address