After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699951 - pyserial_pyper.py needs same results as graph.R
pyserial_pyper.py needs same results as graph.R
Status: RESOLVED FIXED
Product: chronojump
Classification: Other
Component: chronojump
unspecified
Other All
: Normal normal
: ---
Assigned To: Xavier de Blas
Xavier de Blas
Depends on:
Blocks:
 
 
Reported: 2013-05-08 19:17 UTC by Xavier de Blas
Modified: 2015-06-16 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xavier de Blas 2013-05-08 19:17:33 UTC
At graph.R changed start and end of concentric from means of isometric values to the "end of start" (end of bottom concentric) and the "start of end" (start of the top concentric)

Do the same for ec, ecS

Also check if filtering has to be 0.1 on pyserial_pyper.py

Also note that in pyserial_pyper.py propulsive is not counted

do the same for pyserial_pyper_windows.py
Comment 1 Xavier de Blas 2013-05-21 17:48:32 UTC
It's known that graph.R (post) is more accurate than pyserial_pyper.py (capture)

----------------------------
All this without propulsive:

Differences are:

1- End of phase is the same, but start of phase sometimes not.
a) When speed starts with negative values (maybe reduce_curve_by_speed is not working) then it match
b) when speed starts with positive values (reduce_curve... is working) then there are differences in start moment between the two programs

Problem seem to be on pyserial_pyper, that starts on last -1 (of previous curve) instead of on first +1


2.- FIXED!!  when phase start-end is the same in both all the values are the same except mean power

In graph.R 328-330 it's used:
if(eccon == "c")
    meanPower <- mean(kinematics$power)
but in pyserial_pyper.py 204:
myR.run('meanPower <- mean(abs(power))')

then mean power is ABS on concentric at pyserial_pyper, but this is not ok because when accel is lower than -9.81, power should be negative. If you don't want to register this data as negative, the best is to use "propulsive option", and all this negative power will be rejected.


-------------------
Check propulsive stuff (add in pyserial if it is not)
Comment 2 Xavier de Blas 2013-05-30 10:58:20 UTC
All is fixed now except propulsive stuff
Comment 3 Xavier de Blas 2013-06-18 20:18:36 UTC
It still was not ok

No in pyserial done the same method of smoothing than in graph.R

1) first remove at start with reduceCurveBySpeed
2) do speed and accel for curve once reducedCurveBySpeed
3) find propulsive (if appropiate)
4) remove at end with propulsive (if appropiate)

it works quite good, but seem sometimes is not very good doing the reduceCurveBySpeed

graph.R is ok because show same values on data written than on paint graph
Comment 4 Xavier de Blas 2013-06-19 09:54:25 UTC
99% fixed, small differences sometimes