After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699866 - crash in gconf_editor_window_have_icons_notify
crash in gconf_editor_window_have_icons_notify
Status: RESOLVED WONTFIX
Product: gconf-editor
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal critical
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2013-05-07 19:09 UTC by Dmitry Shachnev
Modified: 2018-07-01 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix crashes in gconf_editor_window_have_*_notify (1.14 KB, patch)
2013-05-11 09:58 UTC, Dmitry Shachnev 		none Details | Review

Description Dmitry Shachnev 2013-05-07 19:09:54 UTC 
When trying to unset /desktop/gnome/interface/menus_have_icons, I get this:

+ Trace 231907

  • #0 gconf_editor_window_have_icons_notify
    at gconf-editor-window.c line 1254
  • #1 notify_listeners_callback
    at gconf-client.c line 2810
  • #2 notify_listener_list
    at gconf-listeners.c line 590
  • #3 ltable_notify
    at gconf-listeners.c line 656
  • #4 gconf_listeners_notify
    at gconf-listeners.c line 185
  • #5 notify_one_entry
    at gconf-client.c line 2835
  • #6 gconf_client_flush_notifies
    at gconf-client.c line 2875
  • #7 notify_idle_callback
    at gconf-client.c line 2769 

Something like this should fix the issue (not tested):

--- a/src/gconf-editor-window.c
+++ b/src/gconf-editor-window.c
@@ -1198,7 +1198,7 @@ gconf_editor_window_have_tearoffs_notify (GConfClient       *client,
 {
        gboolean have_tearoffs;
 
-       if (entry->value->type != GCONF_VALUE_BOOL)
+       if (! entry->value || entry->value->type != GCONF_VALUE_BOOL)
                return;
 
        have_tearoffs = gconf_value_get_bool (entry->value);
@@ -1251,7 +1251,7 @@ gconf_editor_window_have_icons_notify (GConfClient       *client,
 {
        gboolean have_icons;
 
-       if (entry->value->type != GCONF_VALUE_BOOL)
+       if (! entry->value || entry->value->type != GCONF_VALUE_BOOL)
                return;
 
        have_icons = gconf_value_get_bool (entry->value);
Comment 1 André Klapper 2013-05-09 05:10:28 UTC 
Patches welcome as attachments, if this is still the case in git master - see https://git.gnome.org/browse/gconf-editor/
Comment 2 Dmitry Shachnev 2013-05-11 09:58:52 UTC 
Created attachment 243840 [details] [review]
Fix crashes in gconf_editor_window_have_*_notify

Fix crash in gconf_editor_window_have_*_notify

Do nothing when entry->value is NULL.

https://bugzilla.gnome.org/show_bug.cgi?id=699866
Comment 3 André Klapper 2018-07-01 08:39:19 UTC 
gconf-editor is not under active development anymore and has not seen code changes for six years. 
Its codebase has been archived: https://gitlab.gnome.org/Archive/gconf-editor/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.