After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699865 - Folks needs to expose chat/VoIP service client types
Folks needs to expose chat/VoIP service client types
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 685971
 
 
Reported: 2013-05-07 19:08 UTC by Travis Reitter
Modified: 2013-07-10 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
client_types property added to PresenceDetails (6.63 KB, patch)
2013-05-07 19:32 UTC, Serhat Rıfat Demircan
committed Details | Review

Description Travis Reitter 2013-05-07 19:08:33 UTC
+++ This bug was initially created as a clone of Bug #685971 +++

Client types describe the type of hardware the client is running on (eg, PC, mobile phone) which may determine how applications interact with those Personas.

This is a requirement for bug #685971
Comment 1 Serhat Rıfat Demircan 2013-05-07 19:32:02 UTC
Created attachment 243531 [details] [review]
client_types property added to PresenceDetails

client_type property added PresenceDetails and impelemented on Folks.Individual and Tpf.Persona.
Comment 2 Philip Withnall 2013-05-10 06:42:22 UTC
Review of attachment 243531 [details] [review]:

Looks good to me, apart from the minor typo below. Please commit to master once you’ve fixed that. Thanks!

::: folks/presence-details.vala
@@ +106,3 @@
+   * from PCs, to phones to consoles.
+   * The client types are represented in strings, using the values 
+   * [[http://xmpp.org/registrar/disco-categories.html#client|documented byXMPP registrar]]

s/byXMPP/by the XMPP/
Comment 3 Philip Withnall 2013-07-01 12:35:39 UTC
Comment on attachment 243531 [details] [review]
client_types property added to PresenceDetails

Committed with the fix.

commit 0659f8b044d7d2845502c07ef775ecf1b854e68a
Author: Serhat Demircan <demircan.serhat@gmail.com>
Date:   Tue May 7 22:27:53 2013 +0300

    core: Add PresenceDetails::client-types and implement on Individual and Tpf.Persona
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=699865

 NEWS                                    |  6 ++++++
 backends/telepathy/lib/tpf-persona.vala | 23 +++++++++++++++++++++++
 folks/individual.vala                   | 15 ++++++++++++++-
 folks/presence-details.vala             | 13 +++++++++++++
 4 files changed, 56 insertions(+), 1 deletion(-)
Comment 4 Travis Reitter 2013-07-10 23:32:08 UTC
Resolving, since this has been committed.