After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699860 - Star / favorite tracks
Star / favorite tracks
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: 3.16
Assigned To: gnome-music-maint
gnome-music-maint
available
: 724535 (view as bug list)
Depends on: 454528
Blocks:
 
 
Reported: 2013-05-07 18:04 UTC by cuidighth
Modified: 2015-02-11 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description cuidighth 2013-05-07 18:04:01 UTC
Add support for reading and writing song ratings from/to the mp3/mp4 files.

The main reasons for doing this are:
* Protection against centralized database corruption - more robust system
* Ability to switch music players without having to go for heavy migrations of database
* Nearly no one who has already rated large amount of songs will change the application if he has to re-rate the contents of the music library again (a task that can take even several years!)
 > This is blocker level issue for wide spread adoption of gnome-music. Ignore this and most of the people will potentially ignore gnome-music.

There are <5 common tag formats in use, for instance Banshee does this (simple bit based system, 255 = 5 stars etc):

# id3v2 -l music.mp3 | grep POPM
POPM (Popularimeter): Banshee, counter=4 rating=255
Comment 1 Vadim Rutkovsky 2013-05-08 08:55:05 UTC
Thanks, interesting suggestion. We get all metadata from tracker store, so as soon as tracker will support rating, we will implement this.
Comment 2 Arnel Borja 2013-07-09 13:14:31 UTC
Grilo supports rating: https://developer.gnome.org/grilo/0.2/GrlMedia.html#grl-media-set-rating

I haven't check if it sets the data directly to the mp3 files though. But even if it doesn't, we could add ratings to gnome-music using grilo and update it later for other features.
Comment 3 Allan Day 2014-04-17 17:16:00 UTC
From a pure user experience level, I'm not a huge fan of ratings. I never know how many stars I'm supposed to give a track that I like. It's too complex, and it creates work to use the feature (since you have to always figure out which rating to give a track).

There is also a UI issue with ratings: we'd need to find space for them in each of the views. I can see this being problematic, particularly in the artists view.

I don't see any point in allowing people to negatively rate a track: the main use case that I think we need to be concerned about is when someone wants to remember a track that they really like.

My preference would be to add the option to "star" tracks: this is simpler and easier to use, fits the relevant use case, and is easier to integrate into the UI.

Changing the status to needinfo (there's no way to change it back to unconfirmed?!), so we can discuss this some more.
Comment 4 Vadim Rutkovsky 2014-04-17 17:53:22 UTC
(In reply to comment #3)
> My preference would be to add the option to "star" tracks: this is simpler and
> easier to use, fits the relevant use case, and is easier to integrate into the
> UI.
Agreed, we have a minimal infrastructure in models, so it would be easy to implement. We can also combine it with playlists - see bug 702519
Comment 5 Allan Day 2014-04-17 18:05:31 UTC
(In reply to comment #4)
...
> Agreed, we have a minimal infrastructure in models, so it would be easy to
> implement. We can also combine it with playlists - see bug 702519

Cool. Updating the title and status. (I'd like to think a bit about how to view the favourites, but we can use this bug for adding the control to star/unstar each track).
Comment 6 Vadim Rutkovsky 2014-04-17 18:09:41 UTC
(In reply to comment #5)
> I'd like to think a bit about how to view the favourites, but we can use this > bug for adding the control to star/unstar each track).
We can start at Songs view and display a togglable start right after the title or album. I guess we can also display a start after track title on other views
Comment 7 Allan Day 2014-04-22 17:08:31 UTC
*** Bug 724535 has been marked as a duplicate of this bug. ***
Comment 8 Vadim Rutkovsky 2015-01-09 11:39:59 UTC
We'll try to have this implemented during 3.16 cycle along with 'Favourite' smart playlist
Comment 9 Maia 2015-02-11 17:13:39 UTC
Implemented in https://bugzilla.gnome.org/show_bug.cgi?id=743901 -- can we close this bug?
Comment 10 Vadim Rutkovsky 2015-02-11 17:16:44 UTC
(In reply to Maia from comment #9)
> Implemented in https://bugzilla.gnome.org/show_bug.cgi?id=743901 -- can we
> close this bug?

Right, closing this one. Separate bugs should be filed if this functionality has issues.