After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699844 - No throttling on screenshot repeat rate
No throttling on screenshot repeat rate
Status: RESOLVED DUPLICATE of bug 737456
Product: gnome-settings-daemon
Classification: Core
Component: plugins
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-07 15:26 UTC by Chris Cummins
Modified: 2015-04-15 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing the series of screenshots taken when holding down the print screen key (up to 25 screenshots per second!) (88.84 KB, image/png)
2013-05-07 15:26 UTC, Chris Cummins
Details

Description Chris Cummins 2013-05-07 15:26:49 UTC
Created attachment 243499 [details]
Screenshot showing the series of screenshots taken when holding down the print screen key (up to 25 screenshots per second!)

As of f33cd1921b4c32eecf54d37d15f9bec0232aa9e3 [1], the print screen button has no rate control over how often it takes screenshots. Previously, holding down and releasing the print screen button resulted in a single screenshot being taken. Under the new implementation [2], there is no limit to how quickly screenshots can be dispatched. Holding down the print screen key results in multiple screenshots being taken in rapid succession as the key auto-repeats; many of the resulting screenshots contain the white `flash' effect, resulting in a totally blank white image (see attached screenshot).

[1] https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=f33cd1921b4c32eecf54d37d15f9bec0232aa9e3

[2] https://bugzilla.gnome.org/show_bug.cgi?id=681844
Comment 1 Bastien Nocera 2013-05-21 07:44:57 UTC
We'd probably need to add a flag so that mutter rate-limits keypresses, or only acts upon key release.
Comment 2 Matthias Clasen 2013-05-21 10:35:30 UTC
Like  bug 336750 ?
Comment 3 Florian Müllner 2013-05-21 10:47:51 UTC
(In reply to comment #2)
> Like  bug 336750 ?

Yup.
Comment 4 Bastien Nocera 2013-05-21 11:51:17 UTC
Is there a mutter version of the bug?
Comment 5 Florian Müllner 2013-05-21 12:09:24 UTC
Not as far as I'm aware, no.
Comment 6 Srdjan Grubor 2015-04-13 20:46:03 UTC
This was fixed with https://bugzilla.gnome.org/show_bug.cgi?id=737456 in the shell so the bug should be closed. I also cannot reproduce this anymore either (3.14.2-0ubuntu1~utopic1)
Comment 7 Bastien Nocera 2015-04-14 09:28:05 UTC
(In reply to Srdjan Grubor from comment #6)
> This was fixed with https://bugzilla.gnome.org/show_bug.cgi?id=737456 in the
> shell so the bug should be closed.

There's no rate limit outside the lock screen...
Comment 8 Florian Müllner 2015-04-14 22:02:06 UTC
(In reply to Bastien Nocera from comment #7)
> (In reply to Srdjan Grubor from comment #6)
> > This was fixed with https://bugzilla.gnome.org/show_bug.cgi?id=737456 in the
> > shell so the bug should be closed.
> 
> There's no rate limit outside the lock screen...

No, the rate limit applies to all screenshots (in fact, screenshots are now disabled on the lock screen, so a rate limit there wouldn't make sense).
Comment 9 Bastien Nocera 2015-04-15 09:46:51 UTC
(In reply to Florian Müllner from comment #8)
> (In reply to Bastien Nocera from comment #7)
> > (In reply to Srdjan Grubor from comment #6)
> > > This was fixed with https://bugzilla.gnome.org/show_bug.cgi?id=737456 in the
> > > shell so the bug should be closed.
> > 
> > There's no rate limit outside the lock screen...
> 
> No, the rate limit applies to all screenshots (in fact, screenshots are now
> disabled on the lock screen, so a rate limit there wouldn't make sense).

None of the bugs linked in this bug have any mention of rate-limiting being implemented in gnome-shell, only the disabling of screenshots in the lock screen.
Comment 10 Florian Müllner 2015-04-15 11:48:28 UTC
The first patch limits screenshot requests to one per sender at any moment, so while there's no particular number called "rate limit", screenshots are throttled by the capacity of the system to grab pixels from the screen and write them to disk.
Comment 11 Bastien Nocera 2015-04-15 13:15:45 UTC
Marking as a dupe of bug 737456 then. Thanks.

*** This bug has been marked as a duplicate of bug 737456 ***