After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699838 - White pause icon
White pause icon
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-07 14:50 UTC by Allan Day
Modified: 2013-05-12 04:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (16.36 KB, image/png)
2013-05-07 14:50 UTC, Allan Day
  Details
The pause and play button now remain dark. (1.13 KB, patch)
2013-05-07 16:42 UTC, Sai Suman Prayaga
none Details | Review
Fix for the Bug in the patch (1.04 KB, patch)
2013-05-08 18:59 UTC, Shivani Poddar
none Details | Review
Fixed the patch for both the variants of adwaita. (1.03 KB, patch)
2013-05-09 05:57 UTC, Sai Suman Prayaga
none Details | Review

Description Allan Day 2013-05-07 14:50:17 UTC
Created attachment 243495 [details]
screenshot

Sometimes it is white. It should always be dark.
Comment 1 Sai Suman Prayaga 2013-05-07 16:42:46 UTC
Created attachment 243509 [details] [review]
The pause and play button now remain dark.
Comment 2 Seif Lotfy 2013-05-07 17:09:13 UTC
Thanks sai
Comment 3 Shivani Poddar 2013-05-08 18:59:23 UTC
Created attachment 243611 [details] [review]
Fix for the Bug in the patch

The Bug was still holding for theme "Adwaita"
Each time the song is paused and then played again from the songs-view list, I encounter http://img.ctrlv.in.s3.amazonaws.com/img/518a64c6352ca.png.
The patch attached fixes this.
Comment 4 Sai Suman Prayaga 2013-05-09 05:57:30 UTC
Created attachment 243672 [details] [review]
Fixed the patch for both the variants of adwaita.
Comment 5 Seif Lotfy 2013-05-09 09:27:57 UTC
Shivani nice work,
Sai please sync with Shivani next time when you are hacking on something she is hacking on, even if it has a bug or is dirty, its better for team work.
Anyhow I will take Sai's patch since it is cleaner and doesn't have Adwaita hardcoded in it.
Cheers :D
Comment 6 Shivani Poddar 2013-05-09 18:17:11 UTC
(In reply to comment #5)
> Shivani nice work,
> Sai please sync with Shivani next time when you are hacking on something she is
> hacking on, even if it has a bug or is dirty, its better for team work.
> Anyhow I will take Sai's patch since it is cleaner and doesn't have Adwaita
> hardcoded in it.
> Cheers :D

Thanks a lot Seif :)
This was heartening :D
Comment 7 Sai Suman Prayaga 2013-05-12 04:22:11 UTC
Shivani, Seif: Sorry, Next time when we are working on the same thing, I'll make sure we are in sync.