GNOME Bugzilla – Bug 699824
No empty state when you have no songs in the Music folder
Last modified: 2013-05-13 06:58:09 UTC
Created attachment 243473 [details] Artist View - Empty State When you have no songs in the Music folder, when you open gnome-music, it just shows a blank window, with some controls in the bottom (see attachment). I was confused by this, thinking some error had occurred, until Andreas pointed me I had no songs in the Music folder. I guess the application should have some empty state as, for example, Documents have: https://github.com/gnome-design-team/gnome-mockups/raw/master/documents/documents-empty.png
Created attachment 243476 [details] Artist View - Empty State Also, the Artist View, when you have no songs in the Music folder, looks even more error-state-ish (The others look like the screenshot for the Albums view)
Oh, Attachment 243473 [details] is Albums View not Artist View.
Visually, I would expect this to be in the same style as the Documents empty state: https://raw.github.com/gnome-design-team/gnome-mockups/master/documents/documents-empty.png We need to make sure that the text matches the possibilities for adding music to your system, of course. I would also remove the Albums / Artists / Songs / Playlists toggles from the toolbar when the application is empty.
Created attachment 243749 [details] [review] Proposed ui for No Music Found Glade file to go with the mockup. Also TODO in the ui the link to "system settings" as described here -> https://raw.github.com/gnome-design-team/gnome-mockups/master/documents/documents-empty.png
Thanks Shivani :D Can you bind it with the code :)
Review of attachment 243749 [details] [review]: This should be loaded initially at artists view and then replaced by existing UI when any artist is found
Created attachment 243953 [details] [review] Solves the bug
Review of attachment 243953 [details] [review]: Good job! However the icon seems misaligned with the text - label should be centered with the icon horizontally
Created attachment 243966 [details] [review] Fixes the Bug Updated patch.
(In reply to comment #8) > Review of attachment 243953 [details] [review]: > > Good job! However the icon seems misaligned with the text - label should be > centered with the icon horizontally Have attached the correct patch now, by mistake put the wrong glade file in the earlier patch :)
Review of attachment 243966 [details] [review]: Thanks, pushed to master
(In reply to comment #11) > Review of attachment 243966 [details] [review]: > > Thanks, pushed to master Thankyou :D