GNOME Bugzilla – Bug 699823
mnemonics don't work with numpad keys
Last modified: 2018-05-02 15:37:39 UTC
A key binding such as ctrl+0 could work with numpad too. Alas, the keycode for keypad is different from the main keyboard so the accel is not found. Perhaps there could be multiple keyvals return per character in gdk_unicode_to_keycode... The gdk_keysym_to_unicode_tab[] already has special case for numpad, so key -> char conversion works. We could special-case in gdk_keyval_to_unicode() too?
I don't think gdk_keyval_to_unicode is involved at all in this code. Also, the key handling code is already too complex, and I'm hesitant to add more complexity to it. If you want to try anyway, gtkkeyhash.c:_gtk_key_hash_lookup is the place to start looking
(In reply to comment #1) > I don't think gdk_keyval_to_unicode is involved at all in this code. oops, I think I meant gdk_unicode_to_keyval().
fyi, we have low priority bugs opened for vv, ex: https://bugzilla.redhat.com/show_bug.cgi?id=883433
Matthias, gtkkeyhash.c:_gtk_key_hash_lookup seems to do the right thing once you have the accel set for both numpad key and the main keyboard one. But seems the problem is not there. AFAIU, Marc-André's suggestion is to, somehow, once you have added the accel for the main keyboard, automatically map with the equivalent on the numpad, right? (Please, correct me if I'm wrong about this). A possible good side-effect is that some applications may use different keys with different meanings and we would break them with this idea. Adding the numpad special case in the gdk_unicode_to_keysym_tab[], as suggested, doesn't help. I've seen that the way applications (and widgets) are treating it is basically adding the accel for the numpad key and this is the way done not only by GTK, but also for another toolkits (at least EFL does the same). So, at this point, two questions: 1) Do we want to support Marc-André's suggestion? 2) Considering we do want to, where is the proper place to start looking for it?
(In reply to comment #4) > AFAIU, Marc-André's suggestion is to, somehow, once you have added the accel > for the main keyboard, automatically map with the equivalent on the numpad, > right? (Please, correct me if I'm wrong about this). yes, we were talking only about label/menu mnemonic at that time though. I am not sure Gtk accel are handled similarly now. > A possible good side-effect is that some applications may use different keys > with different meanings and we would break them with this idea. Perhaps, but not if they only use mnemonics (described in plain text as "ctrl+0" for example here) > Adding the numpad special case in the gdk_unicode_to_keysym_tab[], as > suggested, doesn't help. That's not enough, the function using it would need to handle several keysyms returned: label->mnemonic_keyval = gdk_keyval_to_lower (gdk_unicode_to_keyval (accel_char)); Again this is pretty low priority for us, so we can keep the discussion going but I don't think we should put to much effort on it especially if the potential to break other users is high.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/422.