After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699808 - Album frames should have rounded corners and a lighter color stroke
Album frames should have rounded corners and a lighter color stroke
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Seif Lotfy
gnome-music-maint
Depends on: 700529
Blocks:
 
 
Reported: 2013-05-07 09:23 UTC by Allan Day
Modified: 2013-05-22 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add rounded corners to art work in albums view (3.79 KB, patch)
2013-05-18 00:42 UTC, Seif Lotfy 		committed Details | Review

Description Allan Day 2013-05-07 09:23:58 UTC 
The frame corners should be rounded (the radius is 2.5 in the mockups).

They should also have a lighter color stroke. The mockups use #d3d7cf , which is a common color in the Adwaita palette.

See: https://raw.github.com/gnome-design-team/gnome-mockups/master/music/music-albums.png
Comment 1 Seif Lotfy 2013-05-18 00:42:14 UTC 
Created attachment 244590 [details] [review]
Add rounded corners to art work in albums view
Comment 2 Vadim Rutkovsky 2013-05-19 16:48:36 UTC 
Review of attachment 244590 [details] [review]:

I get:
(gnome-music:5510): Gjs-WARNING **: JS ERROR: ReferenceError: w is not defined
AlbumArtCache<.makeIconFrame@/opt/gnome/share/gnome-music/albumArtCache.js:207

on applying this
Comment 3 Seif Lotfy 2013-05-20 19:12:59 UTC 
Fixed it and pushed to master
Comment 4 Vadim Rutkovsky 2013-05-21 10:49:59 UTC 
Make sure gjs has been compiled with patch from bug 700529.

Seif, this should be reverted before the patch is merged in gjs, what do you think?
Comment 5 Vadim Rutkovsky 2013-05-22 12:21:01 UTC 
GJS bug was fixed, pushing to master as https://git.gnome.org/browse/gnome-music/commit/?id=55500c9d74d7ff0011939ce120a97dd1b8167b70