GNOME Bugzilla – Bug 699807
PlayerToolbar - artist and track name can shrink to nothing
Last modified: 2014-05-12 15:47:06 UTC
Created attachment 243459 [details] screenshot An album cover followed by ... ... looks a bit silly. It's also unhelpful. The solution to this might be to set a larger minimum size for the window.
If we do that, we lose the snap left/right capability. Another question is, do we need the slider to grow with the widow?
Created attachment 243915 [details] [review] New layout Here's a proposition, we pack the prev/play/next buttons on the left, the timer and repeat/shuffle menu to the right, and we leave the center to the labels and the slider, splitting the space 50/50.
Sorry I didn't notice your patch, Guillaume. I think that the width of the player bar is blocking bug 725735. As I wrote there, I think we should consider a player bar design that removes some UI elements (or possibly relocates them to a popover) depending on the available width. This needs design.
Created attachment 275351 [details] [review] PlayerToolbar: Spread out widgets Since the last patch is now almost a year old (tried rebasing it but there are lots of conflicts ;_;) and the mockups for bug 724229 suggests that the progress scale will no longer have to be in the center, I created a new patch here that makes it similar to the said mockups (except the repeat/shuffle menu is still there, which we could easily remove after). I removed the boxes that groups the widgets in the toolbar so that we could distribute them to the artist and title labels, and the progressbar, then added minimum and maximum widths to the labels. Possible enhancements to patch: * Use action bars instead of frame. This will probably remove those custom CSS we use for the player bar. * Separate the widgets using a flow box, if we want to lessen the width of the player bar even more. I'll attach screenshots so you could easily compare the player bar before and after applying the patch.
Created attachment 275352 [details] Screenshot when not maximized Window above is after, below is before applying patch.
Created attachment 275353 [details] Screenshot when maximized Window above is after, below is before applying patch.
Review of attachment 275351 [details] [review]: Looks great, Allan, could you take a look? ::: data/PlayerToolbar.ui @@ -35,3 @@ <property name="no_show_all">True</property> - <style> - <class name="play-bar"/> I guess we're not using play-bar css style anywhere else, so we should also remove it
(In reply to comment #7) > I guess we're not using play-bar css style anywhere else, so we should also > remove it It is currently used for setting the background and the borders, if you want, I could port the bar to use GtkActionBar then bump required GTK+ to 3.12 to remove it.
Just tried using GtkActionBar and it looks similar to current custom styling. Though bumping required GTK+ just to get GtkActionBar is a bit too much I think. What do you think Allan?
Asked Allan and he did agree to the fix. Port to GtkActionBar will be implemented along bug 724229. Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=35b55b56c94125add4b8be11baec07018fe5af98