After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699681 - gnome-clocks shows time incorrectly in RTL languages
gnome-clocks shows time incorrectly in RTL languages
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-04 19:03 UTC by Yosef Or Boczko
Modified: 2013-09-02 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (191.46 KB, image/png)
2013-05-04 19:03 UTC, Yosef Or Boczko
  Details
gnome-control-center screenshot (69.39 KB, image/png)
2013-05-04 19:07 UTC, Yosef Or Boczko
  Details
workaround patch: using a ":" (807 bytes, patch)
2013-05-10 14:23 UTC, Evgeny Bobkin
none Details | Review

Description Yosef Or Boczko 2013-05-04 19:03:56 UTC
Created attachment 243306 [details]
screenshot

In Hebrew, gnome-clocks shows the minutes before the hours.
In the screenshot, it shows 41:21 instead of 21:41.

There is no bug when viewing the settings in gnome-control-center.

I am using git master.
OS: Arch Linux
Comment 1 Yosef Or Boczko 2013-05-04 19:07:39 UTC
Created attachment 243307 [details]
gnome-control-center screenshot
Comment 2 Evgeny Bobkin 2013-05-10 14:22:28 UTC
(In reply to comment #0)
> Created an attachment (id=243306) [details]
> screenshot
> 
> In Hebrew, gnome-clocks shows the minutes before the hours.
> In the screenshot, it shows 41:21 instead of 21:41.
> 
> There is no bug when viewing the settings in gnome-control-center.
> 
> I am using git master.
> OS: Arch Linux
thank you for reporting the issue. It's already a known one, see https://bugzilla.gnome.org/show_bug.cgi?id=696497#c5 for more details.

I can give you a workaround patch, you can try out, which will not probably go upstream, but you can apply it locally, till this issue is officially resolved.
Comment 3 Evgeny Bobkin 2013-05-10 14:23:34 UTC
Created attachment 243787 [details] [review]
workaround patch: using a ":"
Comment 4 André Klapper 2013-07-04 13:32:41 UTC
Also see bug / patch in bug 703569
Comment 5 Evgeny Bobkin 2013-07-17 08:36:37 UTC
One solution I have tried successfully to show the time in RTL language correctly is to mark it for translation and then to replace it by the real ":" character, as was suggested by Matthias Clasen https://bugzilla.gnome.org/show_bug.cgi?id=696497#c10

diff --git a/src/utils.vala b/src/utils.vala
index 3f5ea1d..61e07b7 100644
--- a/src/utils.vala
+++ b/src/utils.vala
@@ -126,7 +126,7 @@ public class WallClock : Object {
 
     public string format_time (GLib.DateTime date_time) {
         // Note that the format uses unicode RATIO and THIN SPACE characters
-        return date_time.format (format == Format.TWELVE ? "%I∶%M %p" : "%H∶%M");
+        return date_time.format (format == Format.TWELVE ? _("%I∶%M %p") : _("%H∶%M"));
     }
 }

and this works. however I have doubts if it's a good solution.

Can the RTL marks or whatever be just straightforward inserted without needing to mark the corresponding string for translation?