After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699587 - wayland: ensure the window is not maximised while being moved
wayland: ensure the window is not maximised while being moved
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-03 14:12 UTC by Thomas Wood
Modified: 2015-02-17 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: ensure the window is not maximised while being moved (1.03 KB, patch)
2013-05-03 14:12 UTC, Thomas Wood
rejected Details | Review

Description Thomas Wood 2013-05-03 14:12:51 UTC
When moving a maximised window, the window should automatically become
un-maximised.
Comment 1 Thomas Wood 2013-05-03 14:12:53 UTC
Created attachment 243185 [details] [review]
wayland: ensure the window is not maximised while being moved
Comment 2 Rob Bradford 2013-05-03 18:38:12 UTC
Review of attachment 243185 [details] [review]:

LGTM.
Comment 3 Rob Bradford 2013-05-03 18:38:13 UTC
Review of attachment 243185 [details] [review]:

LGTM.
Comment 4 Kristian Høgsberg 2013-05-06 16:35:29 UTC
I think this is one of those things that need compositor side support.  Typically you want a little but of motion threshold before you unmaximize and move the window, which has to be done by the compositor.  The application sends a move request as usual and the compositor will check motion against the threshold.  Once the threshold is exceeded, the compositor sends an unaximized event, and when the application responds with new buffer, the compositor can start moving the window.

What's missing here is the request_unmaximize event that allows the compositor to request the application to unmaximize.  The application responds by unmaximizeing and sending a new buffer (renderered with decorations and shadow) at which point the compositor can start moving the surface.
Comment 5 Thomas Wood 2013-06-05 11:00:24 UTC
Comment on attachment 243185 [details] [review]
wayland: ensure the window is not maximised while being moved

I think what Kristian suggested is a better solution for this bug.
Comment 6 Rob Bradford 2013-07-03 16:35:40 UTC
This "request_unmaximise" will come from the work to rethink the state changes as part of the shell revamp.
Comment 7 Matthias Clasen 2015-02-17 17:45:05 UTC
it seems to work acceptably in gnome-shell today.