After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699584 - weird context menu for web app mode
weird context menu for web app mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Web Applications
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-03 13:48 UTC by William Jon McCann
Modified: 2014-10-10 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not show weird context menu entries in app mode (1.66 KB, patch)
2014-08-26 23:21 UTC, Michael Catanzaro 		reviewed Details | Review
Do not show weird context menu entries in app mode (1.24 KB, patch)
2014-08-27 14:09 UTC, Michael Catanzaro 		committed Details | Review

Description William Jon McCann 2013-05-03 13:48:36 UTC 
The context menu in web app mode has "Inspect Element" and "Send Link by Email" (even when not right clicking on a link). Those are both very strange to have in web app mode.
Comment 1 Michael Catanzaro 2014-08-26 23:21:34 UTC 
Created attachment 284564 [details] [review]
Do not show weird context menu entries in app mode

"Inspect Element" and "Send Link by Email" should not be shown in app
mode.
Comment 2 Carlos Garcia Campos 2014-08-27 07:02:39 UTC 
Review of attachment 284564 [details] [review]:

::: src/ephy-window.c
@@ +1788,1 @@
 	g_signal_connect (web_view, "context-menu-dismissed",

I think we can connect the signal earlier and add an early return when in app mode instead of adding another indentation level.
Comment 3 Michael Catanzaro 2014-08-27 14:09:13 UTC 
Created attachment 284607 [details] [review]
Do not show weird context menu entries in app mode

"Inspect element" and "Send Link by Email" should not be shown in app
mdoe.
Comment 4 Carlos Garcia Campos 2014-10-10 08:45:09 UTC 
Comment on attachment 284607 [details] [review]
Do not show weird context menu entries in app mode

I had forgotten this one, sorry.
Comment 5 Michael Catanzaro 2014-10-10 16:00:54 UTC 
Attachment 284607 [details] pushed as ea9e139 - Do not show weird context menu entries in app mode