After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699483 - Change password : button "change" become gray when the password mode is changed
Change password : button "change" become gray when the password mode is changed
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-02 15:36 UTC by Jean-Benoit MARTIN
Modified: 2013-06-11 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check password mode before updating the button sensitivity (1.61 KB, patch)
2013-05-03 15:49 UTC, Jean-Benoit MARTIN
rejected Details | Review
Check password mode before updating the button sensitivity (1.69 KB, patch)
2013-05-27 15:54 UTC, Jean-Benoit MARTIN
committed Details | Review

Description Jean-Benoit MARTIN 2013-05-02 15:36:55 UTC
- Go to user setting
- Unlock to have the password dialogue
- click on password
- choose "set a password now"
- write a wrong password in "Current Password"
- choose an other action for example "Choose password at next login"

The button is grayed after several second

to click on the button "change" we need to change the action and come back on the previous one

It's will be possible to clear all text fill when we choose an other action
Comment 1 Jean-Benoit MARTIN 2013-05-03 15:47:57 UTC
The issue comes from the password authenticate callback auth_cb in panels/user-accounts/um-password-dialog.c

the callback doesn't check if the password mode have changed before updating the button sensitivity
Comment 2 Jean-Benoit MARTIN 2013-05-03 15:49:01 UTC
Created attachment 243208 [details] [review]
Check password mode before updating the button sensitivity
Comment 3 Jean-Benoit MARTIN 2013-05-27 15:52:47 UTC
Review of attachment 243208 [details] [review]:

the mode, model, iter variables are missing
Comment 4 Jean-Benoit MARTIN 2013-05-27 15:52:48 UTC
Review of attachment 243208 [details] [review]:

the mode, model, iter variables are missing
Comment 5 Jean-Benoit MARTIN 2013-05-27 15:54:44 UTC
Created attachment 245394 [details] [review]
Check password mode before updating the button sensitivity
Comment 6 Thomas Wood 2013-06-06 11:24:36 UTC
Review of attachment 245394 [details] [review]:

Patch looks fine to me.
Comment 7 Thomas Wood 2013-06-11 14:40:11 UTC
Pushed to gnome-3-8 branch with a slightly updated commit message. The password
dialog has been re-designed in master and this bug isn't present.