GNOME Bugzilla – Bug 699298
Add Wacom to Tweak Tool
Last modified: 2013-10-18 07:54:14 UTC
Add a Wacom group to Tweak Tool and support for turning on/off the tablet PC mode.
Created attachment 242898 [details] [review] Support using schema paths in GSettings
Created attachment 242899 [details] [review] Add Wacom group and tweak for turning on/off tablet PC mode
See https://bugzilla.gnome.org/show_bug.cgi?id=683568
It depends on a certain patch in libwacom, discussion going on here: https://sourceforge.net/mailarchive/forum.php?thread_name=20130430063302.GA28749%40yabbi.redhat.com&forum_name=linuxwacom-devel
Review of attachment 242899 [details] [review]: Patch looks good, I would only change one thing ::: gtweak/tweaks/tweak_wacom.py @@ +47,3 @@ + ) + return tweaks + I would do this as a TweakGroup, see the following for an example https://git.gnome.org/browse/gnome-tweak-tool/tree/gtweak/tweaks/tweak_shell_extensions.py#n216 https://git.gnome.org/browse/gnome-tweak-tool/tree/gtweak/tweaks/tweak_shell_extensions.py#n249 https://git.gnome.org/browse/gnome-tweak-tool/tree/gtweak/tweaks/tweak_shell_extensions.py#n264 everything else is fine
Created attachment 242910 [details] [review] Add Wacom group and tweak for turning on/off tablet PC mode There you go ;)
Should these tweaks be hidden if libwacom-list-local-devices is not installed if /etc/machine-id is not present (i.e. ubuntu?)
Yeah, I will update the patch to do that. Also, it requires the patch that I mentioned to be applied on that tool, this is going to be tricky to check though.
Created attachment 243160 [details] [review] Add Wacom group and tweak for turning on/off tablet PC mode Hi John, Here is the updated patch. I couldn't figure if you already have a way of telling a group it shouldn't be displayed so I did that ugly hack when adding the Wacom group. If you have a more elegant way to do it, please let me know.
(In reply to comment #9) > Created an attachment (id=243160) [details] [review] > Add Wacom group and tweak for turning on/off tablet PC mode > > Hi John, > > Here is the updated patch. I couldn't figure if you already have a way of > telling a group it shouldn't be displayed so I did that ugly hack when adding > the Wacom group. > > If you have a more elegant way to do it, please let me know. Thanks, this looks great. I need to fix the "hide groups if they contain no tweaks" in g-t-t core. I haven't got around to it yet.
There you go: https://bugzilla.gnome.org/show_bug.cgi?id=699572 May be simplistic but does what's needed. We should think about adding also a var to override this in the TweakGroup because in the future empty groups could maybe want to show a message like "No foo-bar detected, please enable foo-bar by doing bar-foo.".
(In reply to comment #7) > Should these tweaks be hidden if > > libwacom-list-local-devices is not installed > if /etc/machine-id is not present (i.e. ubuntu?) Hi John, About this comment, if any of these fail, the group will have no tweaks and will not be shown so I guess we should consider whether it's a good idea to push this or not. I'd appreciate Ping and Bastien's comments too.
(In reply to comment #12) > > I'd appreciate Ping and Bastien's comments too. I don't know g-t-t enough to make meaningful comments. Just in the sense of consistency, I think we should hide tweaks if anything related to the tweaks is not installed.
Review of attachment 243160 [details] [review]: Looks good then
Review of attachment 242898 [details] [review]: Testing this reveals that it breaks missing schemas/gsettings keys. G-t-t used to ignore these.
Added Alex (GSOC Student) to CC, The feature looks good but I think it breaks missing key/schema support in g-t-t (whereby I used to not crash on missing schemas). Alex, can you track this down?
Attachment 242898 [details] pushed as b04ca60 - Support using schema paths in GSettings Attachment 243160 [details] pushed as 5c58e68 - Add Wacom group and tweak for turning on/off tablet PC mode
I'm reopening this because I had to disable the wacom support for 3.9.90 because I could not test it. The panel needs to be redesigned for the new UI. I will do this, but I need some advice on testing (I don't have a wacom decvice)
Jakub, could you help John with testing?
I think it's actually easier to drop the key from the GSettings in gnome-settings-daemon, and let users that want the support override it with xsetwacom.
Created attachment 252877 [details] [review] wacom: Remove tablet-pc-button config option As it isn't advertised in the main settings, and can be overridden through xsetwacom.
Review of attachment 252877 [details] [review]: Will commit after branching
Was committed along with other wacom fixes for gnome-3-10 and master.