After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699262 - Nullify the gobject cache accessible when the accessible is finalized.
Nullify the gobject cache accessible when the accessible is finalized.
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal major
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-29 20:56 UTC by Alban Browaeys
Modified: 2013-05-06 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Nullify the gobject cache accessible when the accessible is finalized. (1.87 KB, patch)
2013-04-29 20:56 UTC, Alban Browaeys
committed Details | Review

Description Alban Browaeys 2013-04-29 20:56:57 UTC
Created attachment 242846 [details] [review]
Nullify the gobject cache accessible when the accessible is  finalized.

When the gobject is disposed the weak reference finalize
the accessible. But the gobject could still be reference
thus not finalized. As the gobject still holds the accessible
in its qdata, next call to atk_gobject_accessible_for_object
returns the old accessible freed memory. If the caller attempts
to do anything with this memory as if an atkobject it segfaults.

This happens here : gnome-shell segfault when the password prompt
it generates is triggered more than once. As the clutter stage still
 holds a reference to the StIMText, which wasdisposed when the
 password widget was destroyed with the end of the first password
widget, when the second password prompt attempt notify key focus to the
old widget, it gets its accessible (now freed memory) via the StIMText
qdata cache, and pass this to atk_object_notify_state_change.
Comment 1 Alban Browaeys 2013-04-29 21:00:45 UTC
gnome shell backtrace about this atk issue:

Firs gnoem-shell password prompt destroyed (valid):

Breakpoint 1, atk_object_finalize (object=0x415bf40 [CallyText]) at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/atk/atk/atkobject.c:1354
1354	  g_return_if_fail (ATK_IS_OBJECT (object));
(gdb) bt
  • #0 atk_object_finalize
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/atk/atk/atkobject.c line 1354
  • #1 cally_actor_finalize
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/cally/cally-actor.c line 338
  • #2 cally_text_finalize
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/cally/cally-text.c line 260
  • #3 g_object_unref
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 3189
  • #4 atk_gobject_accessible_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/atk/atk/atkgobjectaccessible.c line 149
  • #5 weak_refs_notify
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 2635
  • #6 g_data_set_internal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gdataset.c line 411
  • #7 g_datalist_id_set_data_full
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gdataset.c line 674
  • #8 g_object_real_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1013
  • #9 clutter_actor_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 5836
  • #10 clutter_text_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-text.c line 1444
  • #11 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #12 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #13 st_bin_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-bin.c line 184
  • #14 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #15 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #16 clutter_actor_iter_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 18490
  • #17 clutter_actor_real_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 6095
  • #18 g_cclosure_marshal_VOID__VOID
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gmarshal.c line 85
  • #19 g_type_class_meta_marshal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 970
  • #20 g_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 777
  • #21 signal_emit_unlocked_R
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3700
  • #22 g_signal_emit_valist
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3328
  • #23 g_signal_emit
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3384
  • #24 clutter_actor_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 5782
  • #25 st_widget_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-widget.c line 344
  • #26 st_box_layout_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-box-layout.c line 277
  • #27 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #28 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #29 clutter_actor_iter_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 18490
  • #30 clutter_actor_real_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 6095
  • #31 g_cclosure_marshal_VOID__VOID
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gmarshal.c line 85
  • #32 g_type_class_meta_marshal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 970
  • #33 g_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 777
  • #34 signal_emit_unlocked_R
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3700
  • #35 g_signal_emit_valist
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3328
  • #36 g_signal_emit
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3384
  • #37 clutter_actor_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 5782
  • #38 st_widget_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-widget.c line 344
  • #39 st_box_layout_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-box-layout.c line 277
  • #40 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #41 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #42 clutter_actor_iter_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 18490
  • #44 g_cclosure_marshal_VOID__VOID
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gmarshal.c line 85
  • #45 g_type_class_meta_marshal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 970
  • #46 g_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 777
  • #47 signal_emit_unlocked_R
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3700
  • #48 g_signal_emit_valist
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3328
  • #49 g_signal_emit
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3384
  • #50 clutter_actor_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 5782
  • #51 st_widget_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-widget.c line 344
  • #52 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #53 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #54 st_bin_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-bin.c line 184
  • #55 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #56 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #57 clutter_actor_iter_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 18490
  • #58 clutter_actor_real_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 6095
  • #59 g_cclosure_marshal_VOID__VOID
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gmarshal.c line 85
  • #60 g_type_class_meta_marshal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 970
  • #61 g_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 777
  • #62 signal_emit_unlocked_R
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3700
  • #63 g_signal_emit_valist
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3328
  • #64 g_signal_emit
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3384
  • #65 clutter_actor_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 5782
  • #66 st_widget_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/st/st-widget.c line 344
  • #67 g_object_run_dispose
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gobject.c line 1062
  • #68 clutter_actor_destroy
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-actor.c line 8426
  • #69 ffi_call_unix64
    at ../src/x86/unix64.S line 76
  • #70 ffi_call
    at ../src/x86/ffi64.c line 522
  • #71 gjs_invoke_c_function
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gjs/gi/function.c line 894
  • #72 function_call
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gjs/gi/function.c line 1203
  • #73 CallJSNative
    at ./jscntxtinlines.h line 372
  • #74 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 345
  • #75 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #76 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #77 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #78 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #79 js_fun_apply
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 912
  • #80 CallJSNative
    at ./jscntxtinlines.h line 372
  • #81 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #82 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #83 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #84 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #85 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #86 js::CallOrConstructBoundFunction
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 1039
  • #87 CallJSNative
    at ./jscntxtinlines.h line 372
  • #88 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #89 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #90 js_fun_call
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 830
  • #91 js_fun_apply
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 848
  • #92 CallJSNative
    at ./jscntxtinlines.h line 372
  • #93 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #94 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #95 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #96 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #97 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #98 js_fun_call
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 830
  • #99 js_fun_apply
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 848
  • #100 CallJSNative
    at ./jscntxtinlines.h line 372
  • #101 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #102 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #103 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #104 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #105 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #106 js_fun_apply
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 912
  • #107 CallJSNative
    at ./jscntxtinlines.h line 372
  • #108 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #109 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #110 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #111 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #112 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #113 js_fun_apply
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 912
  • #114 CallJSNative
    at ./jscntxtinlines.h line 372
  • #115 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #116 js::Interpret
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 2414
  • #117 js::RunScript
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 309
  • #118 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 363
  • #119 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #120 js::CallOrConstructBoundFunction
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsfun.cpp line 1039
  • #121 CallJSNative
    at ./jscntxtinlines.h line 372
  • #122 js::InvokeKernel
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 352
  • #123 Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.h line 119
  • #124 js::Invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsinterp.cpp line 396
  • #125 JS_CallFunctionValue
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/js17-17.0.0/js/src/jsapi.cpp line 5851
  • #126 gjs_call_function_value
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gjs/gjs/jsapi-util.c line 718
  • #127 gjs_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gjs/gi/closure.c line 277
  • #128 closure_marshal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gjs/gi/value.c line 130
  • #129 g_closure_invoke
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gclosure.c line 777
  • #130 signal_emit_unlocked_R
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3584
  • #131 g_signal_emit_valist
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3328
  • #132 g_signal_emit
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/gobject/gsignal.c line 3384
  • #133 emit_frame_signal
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-timeline.c line 970
  • #134 clutter_timeline_do_frame
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-timeline.c line 1031
  • #135 _clutter_timeline_do_tick
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-timeline.c line 1761
  • #136 master_clock_advance_timelines
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-master-clock.c line 426
  • #137 clutter_clock_dispatch
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/clutter-master-clock.c line 586
  • #138 g_main_dispatch
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gmain.c line 3058
  • #139 g_main_context_dispatch
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gmain.c line 3634
  • #140 g_main_context_iterate
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gmain.c line 3705
  • #141 g_main_loop_run
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/glib/glib/gmain.c line 3899
  • #142 meta_run
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/mutter/src/core/main.c line 556
  • #143 main
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/gnome-shell/src/main.c line 430
  • #1 cally_stage_notify_key_focus_cb
    at /home/prahal/Projects/Devel/Gnome/jhbuild/gnome/clutter/clutter/cally/cally-stage.c line 146
$1 = 0x7886cf0 [StIMText]
(gdb)
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-04-30 09:49:15 UTC
Review of attachment 242846 [details] [review]:

Looks good
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-05-03 08:16:31 UTC
(In reply to comment #2)
> Review of attachment 242846 [details] [review]:
> 
> Looks good

I noted that I accepted the patch some days ago, but you didn't commit it and in the same time you provided more bugs and patches (thanks!). I assumed that you had commit access. Is that the case? or do you need me to commit your patch?
Comment 4 Alban Browaeys 2013-05-06 09:24:50 UTC
indeed I do not have commit access. I forgot to tell .
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-05-06 11:50:06 UTC
(In reply to comment #4)
> indeed I do not have commit access. I forgot to tell .

Committed in your behalf. Closing the bug. Thanks