GNOME Bugzilla – Bug 699251
classic mode: consider right-click actions on the window list items
Last modified: 2014-04-15 15:30:07 UTC
It has been pointed out to me that both GNOME 2 and Win7 allow to close a window from the window list, with a context menu (or, with grouping, close all grouped windows in one go). We should consider adding something like that back ?
(In reply to comment #0) > (or, with grouping, close all grouped windows in one go) gnome-panel did nested menus in that case *shudder*
What I would like to see there is a possibility to close all grouped windows when right clicking the group (Something like "close all windows"). This menu can be quite simple. Saying "cascade" and "minimize all" maybe as well. There should be a possibility to close just one window from the group via right click as well. This can go with classic menu that would be available for single non grouped panel items.
*** Bug 699883 has been marked as a duplicate of this bug. ***
The right click menu of the window list could also show the same menu as the right click menu from the title bar of a window. For grouped windows the presented options could either be applied to all of the windows or it would need to have a mechanism to distinguish the windows. I suppose the latter would probably need some inelegant ui like nested menus.
Created attachment 245415 [details] [review] window-list: Add context menu gnome-panel's window list had context menus on buttons, that gave easy access to common operations like close, minimize and maximize. Add something similar to the window-list.
Review of attachment 245415 [details] [review]: Looks good.
Review of attachment 245415 [details] [review]: The menu handling is quite broken in my testing here.
That's normal for menus.
Review of attachment 245415 [details] [review]: Yeah, I'm noticing that even the menus that we already had for the application mode (window grouping) buttons have the same problems so let's land this since the code in this patch does look fine.
*** Bug 701862 has been marked as a duplicate of this bug. ***
Would be nice to land this, still. (and ideally backport to f19)
any update ?
Created attachment 250953 [details] [review] window-list: Allow to pop up context menu from keyboard ... so this is why I didn't push the patch before. The patch is meant to be squashed with the other one, just separate for now for ease of review.
florian, were you still going to land this ?
Yes, but as mentioned in comment #13, I'd like to squash the 2nd patch, which is still waiting for review ...
Created attachment 252090 [details] [review] window-list: Fix app button context menu glitch I've detected the problem with context menu in grouped mode. On _windowsChanged callback you refresh the window/app button title and select a proper menu, this._windowContextMenu or this._appContextMenu, but when you select this._windowContextMenu for the proper menu, you leave both menu objects in the _contextMenuManager. This patch must be applied after the above two.
Created attachment 252091 [details] [review] window-list: Added animations to context menu and properly destroy appContextMenu Also please let me add animations to the context menu as the others GNOME Shell menus :D I also realized that _appContextMenu is not destroyed on the _onDestroy callback, is that correct?
Review of attachment 252090 [details] [review]: Oh crap, "this._contextMenuManager.removeMenu(this._appContextMenu);" and "this._contextMenuManager.addMenu(this._appContextMenu);" (lines 452 and 462) must be outside the inner if. I think it's time to go to sleep :(
Review of attachment 250953 [details] [review]: Looks fine to me, and seems very similar to what is done in other places for popup menus in the shell.
there you go, instant review !
Attachment 245415 [details] pushed as f1f16f2 - window-list: Add context menu