After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699227 - external tools: look in file browser root for files named in tool output
external tools: look in file browser root for files named in tool output
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-29 14:20 UTC by Adam Dingle
Modified: 2019-03-23 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (4.74 KB, patch)
2013-04-29 22:21 UTC, Adam Dingle
none Details | Review
fix (4.36 KB, patch)
2013-04-29 22:28 UTC, Adam Dingle
accepted-commit_now Details | Review

Description Adam Dingle 2013-04-29 14:20:19 UTC
Currently the external tools plugin looks in a bunch of different places to find files mentioned in tool output; see externaltools/tools/filelookup.py.  We should add the file browser root as one more place to look.  That way gedit will find files listed by a tool that runs

  cd $GEDIT_FILE_BROWSER_ROOT; grep -R foo

for example.
Comment 1 Adam Dingle 2013-04-29 22:21:58 UTC
Created attachment 242854 [details] [review]
fix

Here's a fix.
Comment 2 Adam Dingle 2013-04-29 22:28:18 UTC
Created attachment 242855 [details] [review]
fix

Oops, didn't get that quite right.  Take 2.
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-04-30 06:17:29 UTC
Review of attachment 242855 [details] [review]:

It looks good to me.
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-04-30 08:44:46 UTC
Adam, you've got the git account already right? When I tried to accept you, I couldn't already, so I guess somebody else did before me. If not lemme know to ping the right people.
Comment 5 Adam Dingle 2013-04-30 10:10:13 UTC
Yes, my account is set up now!  I've pushed the fix.