After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699218 - Resize width in resize.js adds double width for a handle-bar
Resize width in resize.js adds double width for a handle-bar
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.3.1-SVN
Other All
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2013-04-29 12:34 UTC by Goran Rakic
Modified: 2013-05-19 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
One line patch for resize.js (411 bytes, patch)
2013-04-29 12:34 UTC, Goran Rakic 		none Details | Review
Screenshot without a patch (5.04 KB, image/png)
2013-04-29 13:39 UTC, Goran Rakic 		  Details
Screenshot with a patch (6.36 KB, image/png)
2013-04-29 13:40 UTC, Goran Rakic 		  Details

Description Goran Rakic 2013-04-29 12:34:55 UTC 
Created attachment 242793 [details] [review]
One line patch for resize.js

Default navtree.css adds 6px right padding to #side-nav for the handle-bar width.

That is why in file resize.js the result of $(sidenav).outerWidth() called from function resizeWidth() already includes the handle-bar width and we do not need to add additional 6px margin here.
Comment 1 Dimitri van Heesch 2013-04-29 12:49:09 UTC 
Hi Goran,

Thanks for your patch. To better analyse the impact can you explain the problem that you see and which your patch fixes?

On which browsers did you test your patch?
Comment 2 Goran Rakic 2013-04-29 13:39:52 UTC 
Created attachment 242799 [details]
Screenshot without a patch
Comment 3 Goran Rakic 2013-04-29 13:40:12 UTC 
Created attachment 242800 [details]
Screenshot with a patch
Comment 4 Goran Rakic 2013-04-29 13:40:24 UTC 
I am using "Google Chrome 27.0.1453.56 beta".

The issue is that $(sidenav).outerWidth() will include the #side-nav padding, set to 6px to match the handle-bar width. In resize.js on line 41 you are adding this 6px again making a gap.

Attaching the screenshots with and without a patch.
Comment 5 Dimitri van Heesch 2013-04-29 14:27:45 UTC 
Thanks, it is clear now. I'll include the patch in the next subversion update.
Comment 6 Dimitri van Heesch 2013-05-19 12:36:11 UTC 
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.